Re: [HACKERS] orderRules() now a bad idea?

2002-10-17 Thread Bruce Momjian
Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane writes: It looks like NAME comparison uses strcmp (actually strncmp). So it'll be numeric byte-code order. There's no particular reason we couldn't make that be strcoll instead, I suppose, except perhaps speed. But

Re: [HACKERS] orderRules() now a bad idea?

2002-10-17 Thread Peter Eisentraut
Tom Lane writes: I'm confused; are you saying that NAME's sort behavior is good as-is? If not, what would you have it do differently? What I am primarily saying is that ordering the rule execution order alphabetically is not a really good solution. Consequently, I would not go out of my way

Re: [HACKERS] orderRules() now a bad idea?

2002-10-17 Thread Bruce Momjian
Peter Eisentraut wrote: Tom Lane writes: I'm confused; are you saying that NAME's sort behavior is good as-is? If not, what would you have it do differently? What I am primarily saying is that ordering the rule execution order alphabetically is not a really good solution. Consequently,

Re: [HACKERS] orderRules() now a bad idea?

2002-10-17 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane writes: I'm confused; are you saying that NAME's sort behavior is good as-is? If not, what would you have it do differently? What I am primarily saying is that ordering the rule execution order alphabetically is not a really good solution.

Re: [HACKERS] orderRules() now a bad idea?

2002-10-16 Thread Peter Eisentraut
Tom Lane writes: But alphabetical? According to whose definition of the alphabet? It looks like NAME comparison uses strcmp (actually strncmp). So it'll be numeric byte-code order. There's no particular reason we couldn't make that be strcoll instead, I suppose, except perhaps speed.

Re: [HACKERS] orderRules() now a bad idea?

2002-10-16 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane writes: It looks like NAME comparison uses strcmp (actually strncmp). So it'll be numeric byte-code order. There's no particular reason we couldn't make that be strcoll instead, I suppose, except perhaps speed. But how will this work

Re: [HACKERS] orderRules() now a bad idea?

2002-10-15 Thread Jan Wieck
Tom Lane wrote: I just noticed that rewriteHandler.c contains a subroutine orderRules() that reorders the rules for a relation into the order non-instead rules qualified instead rules unqualified instead rules This conflicts with the feature we'd added to 7.3 to

Re: [HACKERS] orderRules() now a bad idea?

2002-10-15 Thread Peter Eisentraut
Bruce Momjian writes: Unless Jan has an objection, I think alpha is best, because it matches trigger rule odering. That original rule ordering isn't something anyone is going to figure out on their own. But alphabetical? According to whose definition of the alphabet? -- Peter Eisentraut

Re: [HACKERS] orderRules() now a bad idea?

2002-10-15 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: But alphabetical? According to whose definition of the alphabet? It looks like NAME comparison uses strcmp (actually strncmp). So it'll be numeric byte-code order. There's no particular reason we couldn't make that be strcoll instead, I suppose,

Re: [HACKERS] orderRules() now a bad idea?

2002-10-14 Thread Bruce Momjian
Tom Lane wrote: I just noticed that rewriteHandler.c contains a subroutine orderRules() that reorders the rules for a relation into the order non-instead rules qualified instead rules unqualified instead rules This conflicts with the feature we'd added to 7.3 to fire rules