Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-11-09 Thread Thom Brown
On 9 November 2011 02:42, Robert Haas robertmh...@gmail.com wrote: On Tue, Nov 8, 2011 at 8:12 PM, Thom Brown t...@linux.com wrote: Why is this marked as done on with Wiki's todo list? I assume you're referring to this item: -- \dd is missing comments for several types of objects.  Comments

Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-11-09 Thread Robert Haas
On Wed, Nov 9, 2011 at 3:38 AM, Thom Brown t...@linux.com wrote: On 9 November 2011 02:42, Robert Haas robertmh...@gmail.com wrote: On Tue, Nov 8, 2011 at 8:12 PM, Thom Brown t...@linux.com wrote: Why is this marked as done on with Wiki's todo list? I assume you're referring to this item:

Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-11-08 Thread Thom Brown
On 17 October 2011 03:04, Robert Haas robertmh...@gmail.com wrote: On Fri, Oct 14, 2011 at 11:12 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Oct 12, 2011 at 10:20 PM, Josh Kupershmidt schmi...@gmail.com wrote: On the third hand, Josh's previous batch of changes to clean up psql's

Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-11-08 Thread Robert Haas
On Tue, Nov 8, 2011 at 8:12 PM, Thom Brown t...@linux.com wrote: Why is this marked as done on with Wiki's todo list? I assume you're referring to this item: -- \dd is missing comments for several types of objects. Comments are not handled at all for some object types, and are handled by both

Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-10-21 Thread Marti Raudsepp
On Mon, Oct 17, 2011 at 05:04, Robert Haas robertmh...@gmail.com wrote: Hearing no cries of oh, yes, please, I'm marking this Returned with Feedback for now.  We can always revisit it if we hear that more people want it. I think this would be an improvement, but it's pretty low on my wishlist.

Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-10-16 Thread Robert Haas
On Fri, Oct 14, 2011 at 11:12 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Oct 12, 2011 at 10:20 PM, Josh Kupershmidt schmi...@gmail.com wrote: On the third hand, Josh's previous batch of changes to clean up psql's behavior in this area are clearly a huge improvement: you can now

Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-10-14 Thread Robert Haas
On Wed, Oct 12, 2011 at 10:20 PM, Josh Kupershmidt schmi...@gmail.com wrote: On the third hand, Josh's previous batch of changes to clean up psql's behavior in this area are clearly a huge improvement: you can now display the comment for nearly anything by running the appropriate \dfoo command

Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-10-12 Thread Robert Haas
On Sun, Sep 11, 2011 at 10:11 AM, Josh Kupershmidt schmi...@gmail.com wrote: On Sat, Sep 10, 2011 at 7:47 PM, Thom Brown t...@linux.com wrote: Just tested this out on current master.  I tried this on every object capable of having a comment, and the view reports all of them with the correct

Re: [HACKERS] pg_comments (was: Allow \dd to show constraint comments)

2011-10-12 Thread Josh Kupershmidt
On Wed, Oct 12, 2011 at 2:49 PM, Robert Haas robertmh...@gmail.com wrote: So, I think the critical question for this patch is do we want this?. Yep. Or put another way, are the gains worth having another system view we'll have to maintain forever? Tom didn't like it, In [1], Tom seemed to be