Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-22 Thread Stefan Kaltenbrunner
On 01/21/2013 08:45 PM, Tom Lane wrote: Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: On 01/21/2013 02:00 PM, Tom Lane wrote: (It's entirely likely that the 7.0 server I keep around for testing this is the last one in captivity anywhere. But IIRC, we've heard fairly recent reports of

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Tom Lane
Pavan Deolasee pavan.deola...@gmail.com writes: On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane t...@sss.pgh.pa.us wrote: As submitted, this broke pg_dump for dumping from pre-8.0 servers. (7.4 didn't accept commas in SET TRANSACTION syntax, and versions before that didn't have the READ ONLY option

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 8:00 AM, Tom Lane t...@sss.pgh.pa.us wrote: Pavan Deolasee pavan.deola...@gmail.com writes: On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane t...@sss.pgh.pa.us wrote: As submitted, this broke pg_dump for dumping from pre-8.0 servers. (7.4 didn't accept commas in SET

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Stefan Kaltenbrunner
On 01/21/2013 02:00 PM, Tom Lane wrote: Pavan Deolasee pavan.deola...@gmail.com writes: On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane t...@sss.pgh.pa.us wrote: As submitted, this broke pg_dump for dumping from pre-8.0 servers. (7.4 didn't accept commas in SET TRANSACTION syntax, and versions

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Tom Lane
Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: On 01/21/2013 02:00 PM, Tom Lane wrote: (It's entirely likely that the 7.0 server I keep around for testing this is the last one in captivity anywhere. But IIRC, we've heard fairly recent reports of people still using 7.2. We'd have to

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-20 Thread Pavan Deolasee
On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane t...@sss.pgh.pa.us wrote: Pavan Deolasee pavan.deola...@gmail.com writes: Sorry for posting on such an old thread. But here is a patch that fixes this. I'm also adding to the next commitfest so that we don't lose track of it again. As submitted, this

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-19 Thread Tom Lane
Pavan Deolasee pavan.deola...@gmail.com writes: Sorry for posting on such an old thread. But here is a patch that fixes this. I'm also adding to the next commitfest so that we don't lose track of it again. As submitted, this broke pg_dump for dumping from pre-8.0 servers. (7.4 didn't accept

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-16 Thread Gurjeet Singh
On Wed, Jan 16, 2013 at 1:21 AM, Pavan Deolasee pavan.deola...@gmail.comwrote: On Wed, Jan 9, 2013 at 6:42 AM, Gurjeet Singh singh.gurj...@gmail.comwrote: I have updated the commitfest submission to link to the correct patch email. Thanks Gurjeet. I initially thought that this

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-15 Thread Pavan Deolasee
On Wed, Jan 9, 2013 at 6:42 AM, Gurjeet Singh singh.gurj...@gmail.comwrote: I have updated the commitfest submission to link to the correct patch email. Thanks Gurjeet. I initially thought that this patch deserves accompanying documentation because pg_dump's serializable transaction may

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-08 Thread Gurjeet Singh
On Mon, Dec 31, 2012 at 1:38 AM, Pavan Deolasee pavan.deola...@gmail.comwrote: On Sun, Dec 30, 2012 at 12:38 AM, Stephen Frost sfr...@snowman.net wrote: * Pavan Deolasee (pavan.deola...@gmail.com) wrote: On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner That makes sense to me. The reason I

Re: [HACKERS] pg_dump transaction's read-only mode

2012-12-30 Thread Pavan Deolasee
On Sun, Dec 30, 2012 at 12:38 AM, Stephen Frost sfr...@snowman.net wrote: * Pavan Deolasee (pavan.deola...@gmail.com) wrote: On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner That makes sense to me. The reason I didn't make that change when I added the serializable special case to pg_dump was

Re: [HACKERS] pg_dump transaction's read-only mode

2012-12-29 Thread Stephen Frost
* Pavan Deolasee (pavan.deola...@gmail.com) wrote: On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner That makes sense to me. The reason I didn't make that change when I added the serializable special case to pg_dump was that it seemed like a separate question; I didn't want to complicate an

Re: [HACKERS] pg_dump transaction's read-only mode

2012-12-06 Thread Pavan Deolasee
On Mon, Sep 10, 2012 at 10:00 PM, Pavan Deolasee pavan.deola...@gmail.com wrote: On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: That makes sense to me. The reason I didn't make that change when I added the serializable special case to pg_dump was that it

Re: [HACKERS] pg_dump transaction's read-only mode

2012-09-10 Thread Pavan Deolasee
On Fri, Sep 7, 2012 at 6:06 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: That makes sense to me. The reason I didn't make that change when I added the serializable special case to pg_dump was that it seemed like a separate question; I didn't want to complicate an already big patch

Re: [HACKERS] pg_dump transaction's read-only mode

2012-09-07 Thread Kevin Grittner
Pavan Deolasee wrote: I'm looking at the following code in pg_dump.c /* * Start transaction-snapshot mode transaction to dump * consistent data. */ ExecuteSqlStatement(fout, BEGIN); if (fout-remoteVersion = 90100) { if (serializable_deferrable)