Re: [HACKERS] pg_stat_statements normalization: re-review

2012-02-24 Thread Daniel Farina
On Thu, Feb 23, 2012 at 3:09 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: These have all been changed in the usual manner to support one new field, the queryId, on the toplevel Plan and Query nodes.  The queryId is 64-bit field copied from queries to plans to tie together plans to be used

Re: [HACKERS] pg_stat_statements normalization: re-review

2012-02-24 Thread Daniel Farina
On Fri, Feb 24, 2012 at 3:14 AM, Daniel Farina dan...@heroku.com wrote: At ExecutorFinish (already hookable) all NodeKeys remembered by an extension should be invalidated, as that memory is free and ready to be used again. I think this statement is false; I thought it was true because *not*

Re: [HACKERS] pg_stat_statements normalization: re-review

2012-02-23 Thread Peter Geoghegan
On 23 February 2012 09:58, Daniel Farina dan...@heroku.com wrote: What I'm going to do here is focus on the back-end source changes that are not part of the contrib.  The size of the changes are much reduced, but their semantics are also somewhat more complex...so, here goes.  Conclusion

Re: [HACKERS] pg_stat_statements normalization: re-review

2012-02-23 Thread Peter Geoghegan
On 23 February 2012 11:09, Peter Geoghegan pe...@2ndquadrant.com wrote: On 23 February 2012 09:58, Daniel Farina dan...@heroku.com wrote: * The small changes to hashing are probably not strictly required, unless collisions are known to get terrible. I imagine that collisions would be rather