Re: [HACKERS] pg_upgrade vs. pg_ctl stop -m fast

2017-01-13 Thread Peter Eisentraut
On 1/13/17 9:45 AM, Peter Eisentraut wrote: > On 1/12/17 9:43 PM, Bruce Momjian wrote: >> On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote: >>> Peter Eisentraut writes: In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". In

Re: [HACKERS] pg_upgrade vs. pg_ctl stop -m fast

2017-01-13 Thread Tom Lane
Peter Eisentraut writes: > On 1/12/17 9:43 PM, Bruce Momjian wrote: >> On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote: >>> Peter Eisentraut writes: I think the last line should be changed to something like

Re: [HACKERS] pg_upgrade vs. pg_ctl stop -m fast

2017-01-13 Thread Peter Eisentraut
On 1/12/17 9:43 PM, Bruce Momjian wrote: > On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote: >> Peter Eisentraut writes: >>> In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". >>> In pg_upgrade, there is this code: >>> ... >>> I

Re: [HACKERS] pg_upgrade vs. pg_ctl stop -m fast

2017-01-12 Thread Bruce Momjian
On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote: > Peter Eisentraut writes: > > In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". > > In pg_upgrade, there is this code: > > ... > > I think the last line should be changed to

Re: [HACKERS] pg_upgrade vs. pg_ctl stop -m fast

2017-01-12 Thread Tom Lane
Peter Eisentraut writes: > In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". > In pg_upgrade, there is this code: > ... > I think the last line should be changed to something like > fast ? "-m fast" : "-m smart"); Ugh.