Re: [HACKERS] pgindent has been run

2006-10-05 Thread Michael Meskes
On Wed, Oct 04, 2006 at 04:41:44PM -0400, Bruce Momjian wrote:
> That will prevent it from being changed by pgindent in the future.

Thanks.

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly


Re: [HACKERS] pgindent has been run

2006-10-04 Thread Bruce Momjian
Joachim Wieland wrote:
> On Wed, Oct 04, 2006 at 06:15:31AM -0400, Bruce Momjian wrote:
> > Michael Meskes wrote:
> > > Is there a way to make pgindent skip a directory? It seems it has
> > > changed all expected file in ecpg's regression suite. So we see a lot of
> > > differences now. 
> 
> > Sure a directory can be skipped.  I am confused how it could change
> > expected files because it only formats C files.
> 
> The .c files that are produced by the ecpg precompiler are in the expected/
> directory as well.
> 
> Instead of skipping this directory  we could also rename them from *.c to
> *.source or similar such that pgindent will not touch them.

I have updated the pgindent script to skip the ecpg regression expected
directory:

find . -name '*.[ch]' -type f -print |
egrep -v '/s_lock.h|src/interfaces/ecpg/test/expected/' |
xargs -n100 pgindent

That will prevent it from being changed by pgindent in the future.

-- 
  Bruce Momjian   [EMAIL PROTECTED]
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 6: explain analyze is your friend


Re: [HACKERS] pgindent has been run

2006-10-04 Thread Michael Paesold

Bruce Momjian schrieb:

Michael Meskes wrote:

On Tue, Oct 03, 2006 at 08:26:36PM -0400, Bruce Momjian wrote:

I have run pgindent for 8.2.

Is there a way to make pgindent skip a directory? It seems it has
changed all expected file in ecpg's regression suite. So we see a lot of
differences now. 


Sure a directory can be skipped.  I am confused how it could change
expected files because it only formats C files.


As far as I understand, ecpg creates .c files.

Best Regards
Michael Paesold


---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [HACKERS] pgindent has been run

2006-10-04 Thread Joachim Wieland
On Wed, Oct 04, 2006 at 06:15:31AM -0400, Bruce Momjian wrote:
> Michael Meskes wrote:
> > Is there a way to make pgindent skip a directory? It seems it has
> > changed all expected file in ecpg's regression suite. So we see a lot of
> > differences now. 

> Sure a directory can be skipped.  I am confused how it could change
> expected files because it only formats C files.

The .c files that are produced by the ecpg precompiler are in the expected/
directory as well.

Instead of skipping this directory  we could also rename them from *.c to
*.source or similar such that pgindent will not touch them.


Joachim


---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq


Re: [HACKERS] pgindent has been run

2006-10-04 Thread Bruce Momjian
Michael Meskes wrote:
> On Tue, Oct 03, 2006 at 08:26:36PM -0400, Bruce Momjian wrote:
> > I have run pgindent for 8.2.
> 
> Is there a way to make pgindent skip a directory? It seems it has
> changed all expected file in ecpg's regression suite. So we see a lot of
> differences now. 

Sure a directory can be skipped.  I am confused how it could change
expected files because it only formats C files.

Seems I need to run the ecpg regressions now as part of my normal
checkin process.

-- 
  Bruce Momjian   [EMAIL PROTECTED]
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org


Re: [HACKERS] pgindent has been run

2006-10-04 Thread Michael Meskes
On Tue, Oct 03, 2006 at 08:26:36PM -0400, Bruce Momjian wrote:
> I have run pgindent for 8.2.

Is there a way to make pgindent skip a directory? It seems it has
changed all expected file in ecpg's regression suite. So we see a lot of
differences now. 

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings