Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-03-02 Thread Marko Tiikkaja
Hi Pavel, The extra semicolons are still in there; around line 525 in this patch. However, I removed them to compile the patch, but I can't compile my plugin on OS X. The plugin is simple, it just does: void _PG_init(void) { DirectFunctionCall1(plpgsql_register_plugin,

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-03-02 Thread Pavel Stehule
Hi 2014-03-02 19:59 GMT+01:00 Marko Tiikkaja ma...@joh.to: Hi Pavel, The extra semicolons are still in there; around line 525 in this patch. However, I removed them to compile the patch, but I can't compile my plugin on OS X. The plugin is simple, it just does: void _PG_init(void) {

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-03-02 Thread Marko Tiikkaja
On 3/2/14, 8:47 PM, Pavel Stehule wrote: 2014-03-02 19:59 GMT+01:00 Marko Tiikkaja ma...@joh.to: Undefined symbols for architecture x86_64: _plpgsql_register_plugin, referenced from: __PG_init in plpgtest.o I'm guessing this is because PL/PgSQL is a shared library and not in core?

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-03-02 Thread Pavel Stehule
Dne 2. 3. 2014 21:55 Marko Tiikkaja ma...@joh.to napsal(a): On 3/2/14, 8:47 PM, Pavel Stehule wrote: 2014-03-02 19:59 GMT+01:00 Marko Tiikkaja ma...@joh.to: Undefined symbols for architecture x86_64: _plpgsql_register_plugin, referenced from: __PG_init in plpgtest.o I'm

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-03-02 Thread Pavel Stehule
2014-03-03 6:09 GMT+01:00 Pavel Stehule pavel.steh...@gmail.com: Dne 2. 3. 2014 21:55 Marko Tiikkaja ma...@joh.to napsal(a): On 3/2/14, 8:47 PM, Pavel Stehule wrote: 2014-03-02 19:59 GMT+01:00 Marko Tiikkaja ma...@joh.to: Undefined symbols for architecture x86_64:

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-02-10 Thread Pavel Stehule
Hello Marko 2014-01-16 23:54 GMT+01:00 Marko Tiikkaja ma...@joh.to: Hi Pavel, First of all, thanks for working on this! On 1/12/14, 8:58 PM, Pavel Stehule wrote: I still not happy with plugin_info - it is only per plugin now and should be per plugin and per function. I'm not sure I

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-02-09 Thread Pavel Stehule
Hello updated patch - now plugin_info is per plpgsq_estate/plugin again. Regards Pavel 2014-01-17 20:26 GMT+01:00 Pavel Stehule pavel.steh...@gmail.com: 2014/1/16 Marko Tiikkaja ma...@joh.to Hi Pavel, First of all, thanks for working on this! On 1/12/14, 8:58 PM, Pavel Stehule

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-01-17 Thread Pavel Stehule
2014/1/16 Marko Tiikkaja ma...@joh.to Hi Pavel, First of all, thanks for working on this! On 1/12/14, 8:58 PM, Pavel Stehule wrote: I still not happy with plugin_info - it is only per plugin now and should be per plugin and per function. I'm not sure I understand the point of

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-01-16 Thread Marko Tiikkaja
Hi Pavel, First of all, thanks for working on this! On 1/12/14, 8:58 PM, Pavel Stehule wrote: I still not happy with plugin_info - it is only per plugin now and should be per plugin and per function. I'm not sure I understand the point of plugin_info in the first place, but what would

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-01-12 Thread Marko Tiikkaja
On 1/9/14, 11:41 PM, Pavel Stehule wrote: There are two basic questions: b) will we support same API still - a reference on plugin_info in exec state is a issue - described in patch. Pardon my ignorance, but why does the plugin_info have to be in the executor state? If we're going to change

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-01-12 Thread Marko Tiikkaja
On 1/12/14, 5:33 PM, I wrote: On 1/9/14, 11:41 PM, Pavel Stehule wrote: There are two basic questions: b) will we support same API still - a reference on plugin_info in exec state is a issue - described in patch. Pardon my ignorance, but why does the plugin_info have to be in the executor

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-01-12 Thread Pavel Stehule
2014/1/12 Marko Tiikkaja ma...@joh.to On 1/12/14, 5:33 PM, I wrote: On 1/9/14, 11:41 PM, Pavel Stehule wrote: There are two basic questions: b) will we support same API still - a reference on plugin_info in exec state is a issue - described in patch. Pardon my ignorance, but why does

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-01-12 Thread Pavel Stehule
Hello Updated version I still not happy with plugin_info - it is only per plugin now and should be per plugin and per function. Regards Pavel 2014/1/12 Pavel Stehule pavel.steh...@gmail.com 2014/1/12 Marko Tiikkaja ma...@joh.to On 1/12/14, 5:33 PM, I wrote: On 1/9/14, 11:41 PM,