Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2016-02-01 Thread Alvaro Herrera
Thomas Munro wrote: > Thinking of other patches in flight, I think I'd want the proposed > N-sync standbys feature to be able to explain in more detail what it's > waiting for (and likewise my causal reads proposal which does that via > the process title), though I realise that the details of

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2016-01-28 Thread Thomas Munro
On Thu, Dec 3, 2015 at 1:00 PM, Craig Ringer wrote: > On 3 December 2015 at 04:22, Julian Schauder > wrote: > >> >> I suggest adding a new state to pg_stat_activity.state for backends that >> are >> >> waiting for their synchronous commit to be

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2016-01-18 Thread Alvaro Herrera
Andres Freund wrote: > On December 4, 2015 9:48:55 AM GMT+01:00, Craig Ringer > wrote: > >On 3 December 2015 at 22:58, Amit Kapila > >wrote: > > > >> On Thu, Dec 3, 2015 at 9:02 AM, Craig Ringer > >> wrote: > >

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2015-12-04 Thread Craig Ringer
On 3 December 2015 at 22:58, Amit Kapila wrote: > On Thu, Dec 3, 2015 at 9:02 AM, Craig Ringer > wrote: > > > > On 3 December 2015 at 09:32, Peter Eisentraut wrote: > >> > >> On 12/2/15 7:00 PM, Craig Ringer wrote: > >> > I

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2015-12-04 Thread Andres Freund
On December 4, 2015 9:48:55 AM GMT+01:00, Craig Ringer wrote: >On 3 December 2015 at 22:58, Amit Kapila >wrote: > >> On Thu, Dec 3, 2015 at 9:02 AM, Craig Ringer >> wrote:

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2015-12-03 Thread Amit Kapila
On Thu, Dec 3, 2015 at 9:02 AM, Craig Ringer wrote: > > On 3 December 2015 at 09:32, Peter Eisentraut wrote: >> >> On 12/2/15 7:00 PM, Craig Ringer wrote: >> > I notice that you don't set the 'waiting' flag. 'waiting' is presently >> > documented as: >> >

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2015-12-02 Thread Craig Ringer
On 3 December 2015 at 04:22, Julian Schauder wrote: > I suggest adding a new state to pg_stat_activity.state for backends that > are > waiting for their synchronous commit to be flushed on the remote host. > > Excellent idea. Anything that improves management and

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2015-12-02 Thread Craig Ringer
On 3 December 2015 at 04:22, Julian Schauder wrote: > > I suggest adding a new state to pg_stat_activity.state for backends that > are > waiting for their synchronous commit to be flushed on the remote host. > I chose 'waiting for synchronous replication' for now. >

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2015-12-02 Thread Craig Ringer
On 3 December 2015 at 09:32, Peter Eisentraut wrote: > On 12/2/15 7:00 PM, Craig Ringer wrote: > > I notice that you don't set the 'waiting' flag. 'waiting' is presently > > documented as: > > > >True if this backend is currently waiting on a lock > > > > ... but I'm

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2015-12-02 Thread Peter Eisentraut
On 12/2/15 7:00 PM, Craig Ringer wrote: > I notice that you don't set the 'waiting' flag. 'waiting' is presently > documented as: > >True if this backend is currently waiting on a lock > > ... but I'm inclined to just widen its definition and set it here, since > we most certainly are