Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-09-10 Thread Pavel Stehule
2014-09-10 0:13 GMT+02:00 Andres Freund and...@2ndquadrant.com: On 2014-09-09 22:22:45 +0200, Andres Freund wrote: I plan to push this soon. Done. Thanks for the patch! Thank you very much Pavel Andres Freund -- Andres Freund http://www.2ndQuadrant.com/

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-09-09 Thread Andres Freund
On 2014-08-28 13:54:28 +0200, Andres Freund wrote: On 2014-08-28 13:20:07 +0200, Andres Freund wrote: I've attached a incremental patch. Apparently I didn't attach the patch, as so much a file containing the name of the patchfile... Which you obviously didn't integrate. And didn't comment

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-09-09 Thread Andres Freund
Hi, Given we already have three topics for --help and I can see others I went with my --help= proposal. On 2014-08-28 13:20:07 +0200, Andres Freund wrote: Some stuff I changed: * I rephrased the sgml changes * s/Printing options/Display options/. Or maybe Display influencing variables?

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-09-09 Thread Andres Freund
On 2014-09-09 22:22:45 +0200, Andres Freund wrote: I plan to push this soon. Done. Thanks for the patch! Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-09-04 Thread Pavel Stehule
Hi here is a second variant with support --help=variables Regards Pavel 2014-09-04 4:25 GMT+02:00 Robert Haas robertmh...@gmail.com: On Thu, Aug 28, 2014 at 11:20 AM, Andres Freund and...@2ndquadrant.com wrote: * How about making it --help=variables instead of --help-variables? -1,

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-09-03 Thread Pavel Stehule
Hello fixed ECHO, ECHO_HIDDEN, PROPMPT Regards Pavel 2014-09-01 11:52 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Thu, Aug 28, 2014 at 9:34 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2014-08-28 14:22 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Thu, Aug 28, 2014

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-09-03 Thread Robert Haas
On Thu, Aug 28, 2014 at 11:20 AM, Andres Freund and...@2ndquadrant.com wrote: * How about making it --help=variables instead of --help-variables? -1, help is not a variable to be assigned imho I don't think variable assignment is a good mental model for long commandline arguments. And it's

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-09-01 Thread Fujii Masao
On Thu, Aug 28, 2014 at 9:34 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2014-08-28 14:22 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Thu, Aug 28, 2014 at 5:48 AM, Pavel Stehule pavel.steh...@gmail.com wrote: comments? +fprintf(output, _( ECHO control what

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-28 Thread Andres Freund
Hi, On 2014-08-27 22:48:54 +0200, Pavel Stehule wrote: Hi I chose \? xxx, because it is related to psql features. I wrote commands: \? options \? variables comments? Generall I like it. Some stuff I changed: * I rephrased the sgml changes * s/Printing options/Display options/. Or

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-28 Thread Fujii Masao
On Thu, Aug 28, 2014 at 8:20 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, On 2014-08-27 22:48:54 +0200, Pavel Stehule wrote: Hi I chose \? xxx, because it is related to psql features. I wrote commands: \? options \? variables comments? Generall I like it. Some stuff I

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-28 Thread Andres Freund
On 2014-08-28 13:20:07 +0200, Andres Freund wrote: I've attached a incremental patch. Apparently I didn't attach the patch, as so much a file containing the name of the patchfile... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-28 Thread Pavel Stehule
2014-08-28 13:20 GMT+02:00 Andres Freund and...@2ndquadrant.com: Hi, On 2014-08-27 22:48:54 +0200, Pavel Stehule wrote: Hi I chose \? xxx, because it is related to psql features. I wrote commands: \? options \? variables comments? Generall I like it. Some stuff I changed:

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-28 Thread Petr Jelinek
On 28/08/14 13:20, Andres Freund wrote: Hi, Stuff I wondered about: * How about making it --help=variables instead of --help-variables? -1, help is not a variable to be assigned imho * Do we really need the 'Report bugs to' blurb for --help-variables? Probably not. * Since we're not

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-28 Thread Fujii Masao
On Thu, Aug 28, 2014 at 5:48 AM, Pavel Stehule pavel.steh...@gmail.com wrote: comments? +fprintf(output, _( ECHO control what input is written to standard output [all, queries]\n)); The valid values in the help messages should be consistent with the values that the

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-28 Thread Pavel Stehule
2014-08-28 14:22 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Thu, Aug 28, 2014 at 5:48 AM, Pavel Stehule pavel.steh...@gmail.com wrote: comments? +fprintf(output, _( ECHO control what input is written to standard output [all, queries]\n)); The valid values in the

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-28 Thread Andres Freund
On 2014-08-28 14:04:27 +0200, Petr Jelinek wrote: On 28/08/14 13:20, Andres Freund wrote: Hi, Stuff I wondered about: * How about making it --help=variables instead of --help-variables? -1, help is not a variable to be assigned imho I don't think variable assignment is a good mental

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-27 Thread Pavel Stehule
Hi I chose \? xxx, because it is related to psql features. I wrote commands: \? options \? variables comments? Regards Pavel 2014-08-26 13:48 GMT+02:00 Andres Freund and...@2ndquadrant.com: On 2014-08-26 13:44:16 +0200, Pavel Stehule wrote: 2014-08-26 13:30 GMT+02:00 Petr Jelinek

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-26 Thread Andres Freund
On 2014-06-29 18:54:50 +0530, Abhijit Menon-Sen wrote: At 2014-06-29 20:35:04 +0900, maumau...@gmail.com wrote: Thanks, I marked it as ready for committer. I hope Fujii san or another committer will commit this, refining English expression if necessary. Since it was just a matter of

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-26 Thread Petr Jelinek
On 26/08/14 13:20, Andres Freund wrote: I'm looking at committing this, but I wonder: Shouldn't this be accessible from inside psql as well? I.e. as a backslash command? +1 -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-26 Thread Pavel Stehule
2014-08-26 13:30 GMT+02:00 Petr Jelinek p...@2ndquadrant.com: On 26/08/14 13:20, Andres Freund wrote: I'm looking at committing this, but I wonder: Shouldn't this be accessible from inside psql as well? I.e. as a backslash command? +1 have you idea about command name? \?+ Pavel

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-26 Thread Andres Freund
On 2014-08-26 13:44:16 +0200, Pavel Stehule wrote: 2014-08-26 13:30 GMT+02:00 Petr Jelinek p...@2ndquadrant.com: On 26/08/14 13:20, Andres Freund wrote: I'm looking at committing this, but I wonder: Shouldn't this be accessible from inside psql as well? I.e. as a backslash command?

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-08-19 Thread Alvaro Herrera
Abhijit Menon-Sen wrote: At 2014-06-29 20:35:04 +0900, maumau...@gmail.com wrote: Thanks, I marked it as ready for committer. I hope Fujii san or another committer will commit this, refining English expression if necessary. Since it was just a matter of editing, I went through the

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-29 Thread Pavel Stehule
Hi 2014-06-29 0:48 GMT+02:00 MauMau maumau...@gmail.com: From: Pavel Stehule pavel.steh...@gmail.com I modified description of setting system variables in dependency on O.S. Thank you, it's almost OK. As mentioned in my previous mail, I think determines should be determine to follow

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-29 Thread MauMau
Thanks, I marked it as ready for committer. I hope Fujii san or another committer will commit this, refining English expression if necessary. Regards MauMau -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-29 Thread Pavel Stehule
2014-06-29 13:35 GMT+02:00 MauMau maumau...@gmail.com: Thanks, I marked it as ready for committer. I hope Fujii san or another committer will commit this, refining English expression if necessary. sure Thank you very much Regards Pavel Regards MauMau

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-29 Thread Abhijit Menon-Sen
At 2014-06-29 20:35:04 +0900, maumau...@gmail.com wrote: Thanks, I marked it as ready for committer. I hope Fujii san or another committer will commit this, refining English expression if necessary. Since it was just a matter of editing, I went through the patch and corrected various minor

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-29 Thread Pavel Stehule
2014-06-29 15:24 GMT+02:00 Abhijit Menon-Sen a...@2ndquadrant.com: At 2014-06-29 20:35:04 +0900, maumau...@gmail.com wrote: Thanks, I marked it as ready for committer. I hope Fujii san or another committer will commit this, refining English expression if necessary. Since it was just a

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-28 Thread Pavel Stehule
Hello I modified description of setting system variables in dependency on O.S. Regards Pavel 2014-06-27 8:54 GMT+02:00 Pavel Stehule pavel.steh...@gmail.com: Hello thank you Peter, so now only setting for MS Windows is missing? Regards Pavel 2014-06-26 21:57 GMT+02:00 Petr

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-28 Thread MauMau
From: Pavel Stehule pavel.steh...@gmail.com I modified description of setting system variables in dependency on O.S. Thank you, it's almost OK. As mentioned in my previous mail, I think determines should be determine to follow other messages. I'll mark this patch as ready for committer

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-27 Thread Pavel Stehule
Hello thank you Peter, so now only setting for MS Windows is missing? Regards Pavel 2014-06-26 21:57 GMT+02:00 Petr Jelinek p...@2ndquadrant.com: Hello, I went through the patch, seems mostly fine, I adjusted some wording, removed the default .pgpass file info since it's not accurate,

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-26 Thread MauMau
Hello, From: Pavel Stehule pavel.steh...@gmail.com fixed Thank you. All is fine. should be Environment variables. And this section lacks description for Windows, such as: + printf(_( NAME=VALUE [NAME=VALUE] psql ...\n or \\setenv NAME [VALUE] in interactive mode\n\n)); + printf(_(

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-26 Thread Pavel Stehule
2014-06-26 15:26 GMT+02:00 MauMau maumau...@gmail.com: Hello, From: Pavel Stehule pavel.steh...@gmail.com fixed Thank you. All is fine. should be Environment variables. And this section lacks description for Windows, such as: + printf(_( NAME=VALUE [NAME=VALUE] psql ...\n or

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-26 Thread Petr Jelinek
Hello, I went through the patch, seems mostly fine, I adjusted some wording, removed the default .pgpass file info since it's not accurate, and replaced couple of phrases with (hopefully) more informative ones. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-25 Thread MauMau
OK, let me help you, though I'm only a Japanese who is never confident in my English. (1) As Fujii-san pointed out, could you add explanation for --help-variables in doc/src/sgml/ref/psqlref.sgml? (2) + printf(_( --help-variables list of available configuration variables

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-25 Thread Pavel Stehule
Hello Here is next update 2014-06-25 17:17 GMT+02:00 MauMau maumau...@gmail.com: OK, let me help you, though I'm only a Japanese who is never confident in my English. (1) As Fujii-san pointed out, could you add explanation for --help-variables in doc/src/sgml/ref/psqlref.sgml? (2) +

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello third version with Erik's update Here are some my comments: The document of psql needs to be updated. At least the description of new option this patch adds needs to be added into the document. +

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Pavel Stehule
Hello 2014-06-23 10:02 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello third version with Erik's update Here are some my comments: The document of psql needs to be updated. At least the description of

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2014-06-23 10:02 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello third version with Erik's update Here are some my

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Pavel Stehule
2014-06-23 10:57 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2014-06-23 10:02 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule pavel.steh...@gmail.com

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Fujii Masao
On Mon, Jun 23, 2014 at 6:06 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2014-06-23 10:57 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2014-06-23 10:02 GMT+02:00 Fujii Masao

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Pavel Stehule
2014-06-23 11:53 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 6:06 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2014-06-23 10:57 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 5:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote:

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-23 Thread Pavel Stehule
Hello I am sending little bit modified patch by Fujii' comments - but I am not able to fix it more - it is task for someone with better English skill then I have Regards Pavel 2014-06-23 10:02 GMT+02:00 Fujii Masao masao.fu...@gmail.com: On Mon, Jun 23, 2014 at 12:04 AM, Pavel Stehule

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-06-22 Thread MauMau
From: Pavel Stehule pavel.steh...@gmail.com pg_dumpall aligns all options left with each other, whether they are short or long. -x, --no-privileges do not dump privileges (grant/revoke) --binary-upgrade for use by upgrade utilities only --column-inserts dump

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-06-22 Thread Pavel Stehule
2014-06-22 9:32 GMT+02:00 MauMau maumau...@gmail.com: From: Pavel Stehule pavel.steh...@gmail.com pg_dumpall aligns all options left with each other, whether they are short or long. -x, --no-privileges do not dump privileges (grant/revoke) --binary-upgrade for use

Re: [Fwd: Re: [HACKERS] proposal: new long psql parameter --on-error-stop]

2014-06-22 Thread Pavel Stehule
those in my patch and improved the text. Attached is the diff against your v1 patch Thanks, Erik Original Message - Subject: Re: [HACKERS] proposal: new long psql parameter

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-06-21 Thread MauMau
eFrom: Pavel Stehule pavel.steh...@gmail.com here is a prototype: The patch applied and built with success. There are a few minor things: (1) help_variables() lacks description of some variables such as SINGLELINE and SINGLESTEP. I think this help should list all available variables,

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-06-21 Thread Pavel Stehule
Hello 2014-06-21 15:51 GMT+02:00 MauMau maumau...@gmail.com: eFrom: Pavel Stehule pavel.steh...@gmail.com here is a prototype: The patch applied and built with success. There are a few minor things: (1) help_variables() lacks description of some variables such as SINGLELINE and

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-06-21 Thread Erik Rijkers
On Sun, June 22, 2014 00:10, Pavel Stehule wrote: [help-variables-01.patch ] +1. This patch is a very useful improvement, IMHO. I edited the text somewhat; and removed some obvious typos. thanks, Erik Rijkers--- src/bin/psql/help.c.orig 2014-06-22 00:31:55.450860460 +0200 +++

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-06-21 Thread MauMau
From: Pavel Stehule pavel.steh...@gmail.com I am not sure in this point. It is aligned left with all long options: -?, --help show this help, then exit --help-variables list of available configuration variables (options), then exit pg_dumpall aligns all options left

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-06-21 Thread Pavel Stehule
2014-06-22 2:26 GMT+02:00 MauMau maumau...@gmail.com: From: Pavel Stehule pavel.steh...@gmail.com I am not sure in this point. It is aligned left with all long options: -?, --help show this help, then exit --help-variables list of available configuration variables

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-03-02 Thread Pavel Stehule
2014-03-01 23:53 GMT+01:00 Fabrízio de Royes Mello fabriziome...@gmail.com : On Sat, Mar 1, 2014 at 5:37 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello here is a prototype: bash-4.1$ /usr/local/pgsql/bin/psql --help-variables List of some variables (options) for use from

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-03-01 Thread Pavel Stehule
Hello here is a prototype: bash-4.1$ /usr/local/pgsql/bin/psql --help-variables List of some variables (options) for use from command line. Complete list you find in psql section in the PostgreSQL documentation. psql variables: Usage: psql --set=NAME=VALUE or \set NAME VALUE in interactive

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-03-01 Thread Fabrízio de Royes Mello
On Sat, Mar 1, 2014 at 5:37 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello here is a prototype: bash-4.1$ /usr/local/pgsql/bin/psql --help-variables List of some variables (options) for use from command line. Complete list you find in psql section in the PostgreSQL documentation.

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: for beginners is relative difficult to set psql variable from command line and option -v ON_ERROR_STOP=1 is little bit unclean. and for any user it is not comfortable. So I propose a new psql option --on-error-stop That saves a whole three

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Pavel Stehule
2014-02-28 19:13 GMT+01:00 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: for beginners is relative difficult to set psql variable from command line and option -v ON_ERROR_STOP=1 is little bit unclean. and for any user it is not comfortable. So I propose a

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Fabrízio de Royes Mello
On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2014-02-28 19:13 GMT+01:00 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: for beginners is relative difficult to set psql variable from command line and option -v ON_ERROR_STOP=1 is

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Pavel Stehule
2014-02-28 19:25 GMT+01:00 Fabrízio de Royes Mello fabriziome...@gmail.com : On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2014-02-28 19:13 GMT+01:00 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: for beginners is relative

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Alvaro Herrera
Fabrízio de Royes Mello escribió: On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule pavel.steh...@gmail.com wrote: important is a placing in --help output Well, then we just have to add more info to --help I think psql could do with some lines for the possible options for --pset (14) and

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Fabrízio de Royes Mello
On Fri, Feb 28, 2014 at 3:44 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello escribió: On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule pavel.steh...@gmail.com wrote: important is a placing in --help output Well, then we just have to add more info to --help

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Pavel Stehule
2014-02-28 19:55 GMT+01:00 Fabrízio de Royes Mello fabriziome...@gmail.com : On Fri, Feb 28, 2014 at 3:44 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello escribió: On Fri, Feb 28, 2014 at 3:17 PM, Pavel Stehule pavel.steh...@gmail.com wrote:

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Andrew Dunstan
On 02/28/2014 01:27 PM, Pavel Stehule wrote: three chars is not important important is a placing in --help output Well, then we just have to add more info to --help it can be solution +1 for at least doing that. I found it annoying just the other day not

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Well, then we just have to add more info to --help +1 for at least doing that. I found it annoying just the other day not to find it in plsql's --help output, in a moment of brain fade when I forgot how to spell it. So it's not just beginners who

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Pavel Stehule
2014-02-28 22:38 GMT+01:00 Tom Lane t...@sss.pgh.pa.us: Andrew Dunstan and...@dunslane.net writes: Well, then we just have to add more info to --help +1 for at least doing that. I found it annoying just the other day not to find it in plsql's --help output, in a moment of brain fade when

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Erik Rijkers
On Fri, February 28, 2014 22:38, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Well, then we just have to add more info to --help +1 for at least doing that. I found it annoying just the other day not to find it in plsql's --help output, in a moment of brain fade when I forgot

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Pavel Stehule
2014-02-28 22:52 GMT+01:00 Erik Rijkers e...@xs4all.nl: On Fri, February 28, 2014 22:38, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Well, then we just have to add more info to --help +1 for at least doing that. I found it annoying just the other day not to find it in

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Andrew Dunstan
On 02/28/2014 04:38 PM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Well, then we just have to add more info to --help +1 for at least doing that. I found it annoying just the other day not to find it in plsql's --help output, in a moment of brain fade when I forgot how to

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Pavel Stehule
2014-02-28 23:01 GMT+01:00 Andrew Dunstan and...@dunslane.net: On 02/28/2014 04:38 PM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Well, then we just have to add more info to --help +1 for at least doing that. I found it annoying just the other day not to find it in

Re: [HACKERS] proposal: new long psql parameter --on-error-stop

2014-02-28 Thread Pavel Stehule
2014-02-28 22:52 GMT+01:00 Erik Rijkers e...@xs4all.nl: e.g.: -v ON_ERROR_STOP=1 I checked it and it is not the most long line there, so it can be a good solution. Pavel