Re: [HACKERS] random isolation test failures

2011-09-27 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar sep 27 01:11:39 -0300 2011: Alvaro Herrera alvhe...@commandprompt.com writes: I just tweaked isolationtester so that it collects the error messages and displays them all together at the end of the test. After seeing it run, I didn't like it -- I

Re: [HACKERS] random isolation test failures

2011-09-27 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of mar sep 27 01:11:39 -0300 2011: Hmm, is that really an appropriate fix? I'm worried that it might mask event-ordering differences that actually are significant. In the attached, it only affects the case

Re: [HACKERS] random isolation test failures

2011-09-26 Thread Kevin Grittner
Andrew Dunstan and...@dunslane.net wrote: We are seeing numerous occasional buildfarm failures of the fk-deadlock2 isolation test If this is harmless, we could provide an alternative results file as a simple fix. If it's not harmless, it should be fixed. I agree, but don't look at me.

Re: [HACKERS] random isolation test failures

2011-09-26 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: We are seeing numerous occasional buildfarm failures of the fk-deadlock2 isolation test, Yeah, I complained about this already, but Kevin disclaims all responsibility for the fk isolation tests. It looks like Alvaro and Noah Misch are the people to

Re: [HACKERS] random isolation test failures

2011-09-26 Thread Noah Misch
On Mon, Sep 26, 2011 at 01:10:27PM -0400, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: We are seeing numerous occasional buildfarm failures of the fk-deadlock2 isolation test, Yeah, I complained about this already, but Kevin disclaims all responsibility for the fk isolation

Re: [HACKERS] random isolation test failures

2011-09-26 Thread Alvaro Herrera
Excerpts from Noah Misch's message of lun sep 26 21:57:40 -0300 2011: These sporadic failures happen whenever the test case takes longer than deadlock_timeout (currently 100ms for these tests) to setup the deadlock. I outlined some mitigating strategies here:

Re: [HACKERS] random isolation test failures

2011-09-26 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: I just tweaked isolationtester so that it collects the error messages and displays them all together at the end of the test. After seeing it run, I didn't like it -- I think I prefer something more local, so that in the only case where we call