Re: [HACKERS] save redundant code for pseudotype I/O functions

2016-11-01 Thread Peter Eisentraut
On 10/28/16 9:25 AM, Tom Lane wrote: > Would it be better to use CppAsString and CppConcat instead of directly > using # and ##, for consistency with what we do elsewhere? I modeled this after several similar places in gin and tsearch code, which use ##: contrib/btree_gin/btree_gin.c

Re: [HACKERS] save redundant code for pseudotype I/O functions

2016-10-28 Thread Tom Lane
Peter Eisentraut writes: > On 10/27/16 11:49 PM, Peter Eisentraut wrote: >> Here is a patch to refactor some of the I/O functions in pseudotypes.c >> to save redundant code and reduce the number of distinct translatable >> strings. Would it be better to use

Re: [HACKERS] save redundant code for pseudotype I/O functions

2016-10-27 Thread Peter Eisentraut
On 10/27/16 11:49 PM, Peter Eisentraut wrote: > Here is a patch to refactor some of the I/O functions in pseudotypes.c > to save redundant code and reduce the number of distinct translatable > strings. And here is the actual patch. -- Peter Eisentraut http://www.2ndQuadrant.com/