Re: [HACKERS] several problems in pg_receivexlog

2012-08-06 Thread Magnus Hagander
On Tue, Jul 31, 2012 at 6:50 PM, Fujii Masao wrote: > On Wed, Aug 1, 2012 at 12:09 AM, Alvaro Herrera > wrote: >> >> Excerpts from Fujii Masao's message of mar jul 17 13:58:38 -0400 2012: >> >>> >> You're right. If the error is detected, that function always returns >>> >> false >>> >> and the e

Re: [HACKERS] several problems in pg_receivexlog

2012-08-06 Thread Magnus Hagander
On Tue, Jul 31, 2012 at 5:06 PM, Alvaro Herrera wrote: > > Excerpts from Magnus Hagander's message of jue jul 12 07:35:11 -0400 2012: >> On Tue, Jul 10, 2012 at 6:45 PM, Fujii Masao wrote: > >> > When an error happens after replication connection has been established, >> > pg_receivexlog doesn't

Re: [HACKERS] several problems in pg_receivexlog

2012-07-31 Thread Fujii Masao
On Wed, Aug 1, 2012 at 12:09 AM, Alvaro Herrera wrote: > > Excerpts from Fujii Masao's message of mar jul 17 13:58:38 -0400 2012: > >> >> You're right. If the error is detected, that function always returns false >> >> and the error message is emitted (but I think that current error message >> >>

Re: [HACKERS] several problems in pg_receivexlog

2012-07-31 Thread Alvaro Herrera
Excerpts from Fujii Masao's message of mar jul 17 13:58:38 -0400 2012: > >> You're right. If the error is detected, that function always returns false > >> and the error message is emitted (but I think that current error message > >> "pg_basebackup: child process exited with error 1" is confusing

Re: [HACKERS] several problems in pg_receivexlog

2012-07-31 Thread Alvaro Herrera
Excerpts from Magnus Hagander's message of jue jul 12 07:35:11 -0400 2012: > On Tue, Jul 10, 2012 at 6:45 PM, Fujii Masao wrote: > > When an error happens after replication connection has been established, > > pg_receivexlog doesn't close an open file descriptor and release an > > allocated > >

Re: [HACKERS] several problems in pg_receivexlog

2012-07-17 Thread Fujii Masao
On Fri, Jul 13, 2012 at 1:15 AM, Magnus Hagander wrote: > On Thu, Jul 12, 2012 at 6:07 PM, Fujii Masao wrote: >> On Thu, Jul 12, 2012 at 8:39 PM, Magnus Hagander wrote: >>> On Tue, Jul 10, 2012 at 7:03 PM, Fujii Masao wrote: On Tue, Jul 10, 2012 at 3:23 AM, Fujii Masao wrote: > Hi, >>

Re: [HACKERS] several problems in pg_receivexlog

2012-07-12 Thread Magnus Hagander
On Thu, Jul 12, 2012 at 6:07 PM, Fujii Masao wrote: > On Thu, Jul 12, 2012 at 8:39 PM, Magnus Hagander wrote: >> On Tue, Jul 10, 2012 at 7:03 PM, Fujii Masao wrote: >>> On Tue, Jul 10, 2012 at 3:23 AM, Fujii Masao wrote: Hi, I found several problems in pg_receivexlog, e.g., memor

Re: [HACKERS] several problems in pg_receivexlog

2012-07-12 Thread Fujii Masao
On Thu, Jul 12, 2012 at 8:39 PM, Magnus Hagander wrote: > On Tue, Jul 10, 2012 at 7:03 PM, Fujii Masao wrote: >> On Tue, Jul 10, 2012 at 3:23 AM, Fujii Masao wrote: >>> Hi, >>> >>> I found several problems in pg_receivexlog, e.g., memory leaks, >>> file-descripter leaks, ..etc. The attached patc

Re: [HACKERS] several problems in pg_receivexlog

2012-07-12 Thread Magnus Hagander
On Tue, Jul 10, 2012 at 7:03 PM, Fujii Masao wrote: > On Tue, Jul 10, 2012 at 3:23 AM, Fujii Masao wrote: >> Hi, >> >> I found several problems in pg_receivexlog, e.g., memory leaks, >> file-descripter leaks, ..etc. The attached patch fixes these problems. >> >> ISTM there are still some other pr

Re: [HACKERS] several problems in pg_receivexlog

2012-07-12 Thread Magnus Hagander
On Tue, Jul 10, 2012 at 6:45 PM, Fujii Masao wrote: > On Tue, Jul 10, 2012 at 6:27 AM, Magnus Hagander wrote: >> On Mon, Jul 9, 2012 at 8:23 PM, Fujii Masao wrote: >>> Hi, >>> >>> I found several problems in pg_receivexlog, e.g., memory leaks, >>> file-descripter leaks, ..etc. The attached patch

Re: [HACKERS] several problems in pg_receivexlog

2012-07-10 Thread Fujii Masao
On Tue, Jul 10, 2012 at 3:23 AM, Fujii Masao wrote: > Hi, > > I found several problems in pg_receivexlog, e.g., memory leaks, > file-descripter leaks, ..etc. The attached patch fixes these problems. > > ISTM there are still some other problems in pg_receivexlog, so I'll > read it deeply later. Wh

Re: [HACKERS] several problems in pg_receivexlog

2012-07-10 Thread Fujii Masao
On Tue, Jul 10, 2012 at 6:27 AM, Magnus Hagander wrote: > On Mon, Jul 9, 2012 at 8:23 PM, Fujii Masao wrote: >> Hi, >> >> I found several problems in pg_receivexlog, e.g., memory leaks, >> file-descripter leaks, ..etc. The attached patch fixes these problems. > > While I don't doubt that what you

Re: [HACKERS] several problems in pg_receivexlog

2012-07-09 Thread Magnus Hagander
On Mon, Jul 9, 2012 at 8:23 PM, Fujii Masao wrote: > Hi, > > I found several problems in pg_receivexlog, e.g., memory leaks, > file-descripter leaks, ..etc. The attached patch fixes these problems. While I don't doubt that what you've found are real problems, would you mind explaining exactly wha