Re: [HACKERS] synchronous_commit option is not visible after pressing TAB

[Masahiko Sawada]

On Wed, May 17, 2017 at 11:21 AM, Peter Eisentraut
 wrote:
> On 5/16/17 19:45, Michael Paquier wrote:
>> On Tue, May 16, 2017 at 8:18 PM, tushar  
>> wrote:
>>> While creating subscription - if we press TAB button to see the available
>>> parameters , synchronous_commit parameter is not visible.
>>>
>>> postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
>>> PUBLICATION pub WITH (
>>> CONNECT  COPY_DATACREATE_SLOT  ENABLED  SLOT_NAME
>>>
>>> synchronous_commit option is not visible
>>
>> Yes, and the items should be ordered alphabetically.
>
> Fixed.  There were a few more things that needed tweaking, too.
>

In addition to that, attached patch fixes two tab completion issues.

* ALTER SUBSCRIPTION hoge_sub SET PUBLICATION hoge_pub [TAB]
  -> Complete with "REFRESH ..." or "SKIP REFRESH".
* CREATE PUBLICATION hoge_pub FOR ALL TABLES [TAB] and CREATE
PUBLICATION hoge_pub FOR TABLE hoge_table [TAB]
  -> Complete with "WITH ("

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


fix_tab_completion.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] synchronous_commit option is not visible after pressing TAB

[Peter Eisentraut]

On 5/16/17 19:45, Michael Paquier wrote:
> On Tue, May 16, 2017 at 8:18 PM, tushar  wrote:
>> While creating subscription - if we press TAB button to see the available
>> parameters , synchronous_commit parameter is not visible.
>>
>> postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
>> PUBLICATION pub WITH (
>> CONNECT  COPY_DATACREATE_SLOT  ENABLED  SLOT_NAME
>>
>> synchronous_commit option is not visible
> 
> Yes, and the items should be ordered alphabetically.

Fixed.  There were a few more things that needed tweaking, too.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] synchronous_commit option is not visible after pressing TAB

[Michael Paquier]

On Tue, May 16, 2017 at 8:18 PM, tushar  wrote:
> While creating subscription - if we press TAB button to see the available
> parameters , synchronous_commit parameter is not visible.
>
> postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
> PUBLICATION pub WITH (
> CONNECT  COPY_DATACREATE_SLOT  ENABLED  SLOT_NAME
>
> synchronous_commit option is not visible

Yes, and the items should be ordered alphabetically.
-- 
Michael


create-sub-tab.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers