Re: [HACKERS] wait events for disk I/O

2017-03-20 Thread Rajkumar Raghuwanshi
On Sat, Mar 18, 2017 at 10:52 PM, Rushabh Lathia wrote: > > > On Sat, Mar 18, 2017 at 5:15 PM, Robert Haas wrote: >> >> On Fri, Mar 17, 2017 at 10:01 AM, Rushabh Lathia >> wrote: >> > I tried to cover all the suggestion

Re: [HACKERS] wait events for disk I/O

2017-03-18 Thread Rushabh Lathia
On Sat, Mar 18, 2017 at 5:15 PM, Robert Haas wrote: > On Fri, Mar 17, 2017 at 10:01 AM, Rushabh Lathia > wrote: > > I tried to cover all the suggestion in the attached latest patch. > > Committed. I reworded the documentation entries, renamed a

Re: [HACKERS] wait events for disk I/O

2017-03-18 Thread Robert Haas
On Fri, Mar 17, 2017 at 10:01 AM, Rushabh Lathia wrote: > I tried to cover all the suggestion in the attached latest patch. Committed. I reworded the documentation entries, renamed a few of the wait events to make things more consistent, put all three lists in rigorous

Re: [HACKERS] wait events for disk I/O

2017-03-17 Thread Rushabh Lathia
Thanks Robert for the review. On Thu, Mar 16, 2017 at 8:05 PM, Robert Haas wrote: > On Thu, Mar 16, 2017 at 8:28 AM, Rahila Syed > wrote: > > Thank you for the updated patch. > > > > I have applied and tested it on latest sources and the patch

Re: [HACKERS] wait events for disk I/O

2017-03-16 Thread Robert Haas
On Thu, Mar 16, 2017 at 8:28 AM, Rahila Syed wrote: > Thank you for the updated patch. > > I have applied and tested it on latest sources and the patch looks good to > me. The documentation puts the new wait events in a pretty random order. I think they should be

Re: [HACKERS] wait events for disk I/O

2017-03-16 Thread Rahila Syed
Thank you for the updated patch. I have applied and tested it on latest sources and the patch looks good to me. >I am not quite sure about this, as this is for stat statements. Also part from the >place you found there are many other fwrite() call into pg_stat_statements, and >I intentionally

Re: [HACKERS] wait events for disk I/O

2017-03-15 Thread Rushabh Lathia
Thanks Rahila for reviewing this patch. On Tue, Mar 14, 2017 at 8:13 PM, Rahila Syed wrote: > Hello, > > I applied and tested this patch on latest sources and it works fine. > > Following are some comments, > > >+ /* Wait event for SNRU */ > >+

Re: [HACKERS] wait events for disk I/O

2017-03-14 Thread Rahila Syed
Hello, I applied and tested this patch on latest sources and it works fine. Following are some comments, >+ /* Wait event for SNRU */ >+ WAIT_EVENT_READ_SLRU_PAGE, Typo in the comment. >FileWriteback(v->mdfd_vfd, seekpos, (off_t) BLCKSZ * nflush, WAIT_EVENT_FLUSH_DATA_BLOCK); This call is

Re: [HACKERS] wait events for disk I/O

2017-03-12 Thread Rajkumar Raghuwanshi
On Thu, Mar 9, 2017 at 10:54 AM, Rushabh Lathia wrote: > Thanks Rajkumar for performing tests on this patch. > > Yes, I also noticed similar results in my testing. Additionally sometime I > also > noticed ReadSLRUPage event on my system. > > I also run the reindex

Re: [HACKERS] wait events for disk I/O

2017-03-08 Thread Rushabh Lathia
Thanks Rajkumar for performing tests on this patch. Yes, I also noticed similar results in my testing. Additionally sometime I also noticed ReadSLRUPage event on my system. I also run the reindex database command and I notices below IO events. SyncImmedRelation, WriteDataBlock WriteBuffile,

Re: [HACKERS] wait events for disk I/O

2017-03-08 Thread Rajkumar Raghuwanshi
On Wed, Mar 8, 2017 at 4:50 PM, Rushabh Lathia wrote: > I am attaching another version of the patch, as I found stupid mistake > in the earlier version of patch, where I missed to initialize initial > value to > WaitEventIO enum. Also earlier version was not getting

Re: [HACKERS] wait events for disk I/O

2017-03-08 Thread Rushabh Lathia
On Wed, Mar 8, 2017 at 8:23 AM, Robert Haas wrote: > On Tue, Mar 7, 2017 at 9:32 PM, Amit Kapila > wrote: > > On Tue, Mar 7, 2017 at 9:16 PM, Robert Haas > wrote: > >> On Mon, Mar 6, 2017 at 9:09 PM, Amit Kapila

Re: [HACKERS] wait events for disk I/O

2017-03-07 Thread Robert Haas
On Tue, Mar 7, 2017 at 9:32 PM, Amit Kapila wrote: > On Tue, Mar 7, 2017 at 9:16 PM, Robert Haas wrote: >> On Mon, Mar 6, 2017 at 9:09 PM, Amit Kapila wrote: >>> Sure, if you think both Writes and Reads at OS level can

Re: [HACKERS] wait events for disk I/O

2017-03-07 Thread Amit Kapila
On Tue, Mar 7, 2017 at 9:16 PM, Robert Haas wrote: > On Mon, Mar 6, 2017 at 9:09 PM, Amit Kapila wrote: >> Sure, if you think both Writes and Reads at OS level can have some >> chance of blocking in obscure cases, then we should add a wait event >>

Re: [HACKERS] wait events for disk I/O

2017-03-07 Thread Robert Haas
On Mon, Mar 6, 2017 at 9:09 PM, Amit Kapila wrote: > Sure, if you think both Writes and Reads at OS level can have some > chance of blocking in obscure cases, then we should add a wait event > for them. I think writes have a chance of blocking in cases even in cases that

Re: [HACKERS] wait events for disk I/O

2017-03-06 Thread Amit Kapila
On Tue, Mar 7, 2017 at 5:27 AM, Robert Haas wrote: > On Mon, Mar 6, 2017 at 3:27 AM, Rushabh Lathia > wrote: >> Yes, I thought of adding wait event only for the sync but then recording the >> wait event for both write and sync. I understand that

Re: [HACKERS] wait events for disk I/O

2017-03-06 Thread Michael Paquier
On Tue, Mar 7, 2017 at 8:57 AM, Robert Haas wrote: > On Mon, Mar 6, 2017 at 3:27 AM, Rushabh Lathia > wrote: >> Yes, I thought of adding wait event only for the sync but then recording the >> wait event for both write and sync. I understand that

Re: [HACKERS] wait events for disk I/O

2017-03-06 Thread Robert Haas
On Mon, Mar 6, 2017 at 3:27 AM, Rushabh Lathia wrote: > Yes, I thought of adding wait event only for the sync but then recording the > wait event for both write and sync. I understand that OS level writes are > cheap but it still have some cost attached to that. Also I

Re: [HACKERS] wait events for disk I/O

2017-03-06 Thread Rushabh Lathia
On Sat, Mar 4, 2017 at 7:53 PM, Amit Kapila wrote: > On Mon, Feb 20, 2017 at 4:04 PM, Rushabh Lathia > wrote: > > > > My colleague Rahila reported compilation issue with > > the patch. Issue was only coming with we do the clean > > build on the

Re: [HACKERS] wait events for disk I/O

2017-03-04 Thread Amit Kapila
On Mon, Feb 20, 2017 at 4:04 PM, Rushabh Lathia wrote: > > My colleague Rahila reported compilation issue with > the patch. Issue was only coming with we do the clean > build on the branch. > > Fixed the same into latest version of patch. > Few assorted comments: 1. +

Re: [HACKERS] wait events for disk I/O

2017-02-20 Thread Rushabh Lathia
My colleague Rahila reported compilation issue with the patch. Issue was only coming with we do the clean build on the branch. Fixed the same into latest version of patch. Thanks, On Tue, Jan 31, 2017 at 11:09 AM, Rushabh Lathia wrote: > > > On Tue, Jan 31, 2017 at

Re: [HACKERS] wait events for disk I/O

2017-01-30 Thread Rushabh Lathia
On Tue, Jan 31, 2017 at 8:54 AM, Michael Paquier wrote: > On Mon, Jan 30, 2017 at 10:01 PM, Rushabh Lathia > wrote: > > Attached is the patch, which extend the existing wait event > infrastructure > > to implement the wait events for the disk

Re: [HACKERS] wait events for disk I/O

2017-01-30 Thread Michael Paquier
On Mon, Jan 30, 2017 at 10:01 PM, Rushabh Lathia wrote: > Attached is the patch, which extend the existing wait event infrastructure > to implement the wait events for the disk I/O. Basically pg_stat_activity's > wait event information to show data about disk I/O as well