Re: [PATCHES] [HACKERS] psql commandline conninfo

2006-12-17 Thread Andrew Dunstan
Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: OK, good to know. Does the patch need documentation too? Certainly. That's why I haven't committed it yet. I intend to put info in the psql manual as well as in the libpq reference. Are we deprecating the psql opti

Re: [PATCHES] [HACKERS] psql commandline conninfo

2006-12-17 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > OK, good to know. Does the patch need documentation too? Certainly. > Are we > deprecating the psql options now duplicated by the new functionality, > like host/port/username/password? I'd vote not. This is just another way to do it.

Re: [PATCHES] [HACKERS] psql commandline conninfo

2006-12-17 Thread Bruce Momjian
Andrew Dunstan wrote: > Bruce Momjian wrote: > > > > I assume this patch will still allow a database name with an equals > > sign, right? > > > > > > psql "dbname='a=b'" > > > Yes. In fact, reading the code it looks like the quotes are not necessary > in this case. OK, good to know. Does th

Re: [PATCHES] [HACKERS] psql commandline conninfo

2006-12-16 Thread Andrew Dunstan
Bruce Momjian wrote: > > I assume this patch will still allow a database name with an equals > sign, right? > > > psql "dbname='a=b'" Yes. In fact, reading the code it looks like the quotes are not necessary in this case. cheers andrew ---(end of broadcast)--

Re: [PATCHES] [HACKERS] psql commandline conninfo

2006-12-16 Thread Bruce Momjian
I assume this patch will still allow a database name with an equals sign, right? psql "dbname='a=b'" The libpq documentation isn't clear that single-quotes also escape equals, but I assume that is true looking at the code: http://www.postgresql.org/docs/8.2/static/libpq-connec

Re: [PATCHES] [HACKERS] psql commandline conninfo

2006-12-16 Thread Tom Lane
"Andrew Dunstan" <[EMAIL PROTECTED]> writes: > BTW, what is the approved way to handle warnings about const? Copy the > object? Well, in the revised code there shouldn't be any warning at all, but I think the mistake in your original was to declare the local variable as "char *" instead of "const