Re: [JDBC] Re: Proposal to fix Statement.executeBatch()

2001-09-05 Thread Bruce Momjian
Barry, I just applied this patch and a few others. Let me know if they are OK. > Rene, > > This writeup looks good. As for your two followup questions: > > 1) I agree with your opinion on the select issue. Since selects are > the only way to call functions and functions could themselves

Re: [JDBC] Re: Proposal to fix Statement.executeBatch()

2001-09-05 Thread Barry Lind
Rene, This writeup looks good. As for your two followup questions: 1) I agree with your opinion on the select issue. Since selects are the only way to call functions and functions could themselves be doing inserts/updates, to not allow selects is a bad idea IMHO. 2) The 8K limitation was

Re: [JDBC] Re: Proposal to fix Statement.executeBatch()

2001-09-01 Thread Rene Pijlman
On Mon, 27 Aug 2001 22:57:13 -0700, Barry Lind wrote: >I do not know what the server does if you have autocommit enabled >and you issue multiple statements in one try. As you know, Peter Eisentraut said on hackers that all statements in a semicolon-separated query string are processed as one sin

Re: [JDBC] Re: Proposal to fix Statement.executeBatch()

2001-08-28 Thread Bruce Momjian
No problem. Just checking. Patch will remain in the queue and be applied. > Bruce, > > I think the existing patch can be applied as is. The issues I raised > below are further improvements in the functionality that can be done and > don't directly relate to the patch that was submitted. S

[JDBC] Re: Proposal to fix Statement.executeBatch()

2001-08-28 Thread Barry Lind
Bruce, I think the existing patch can be applied as is. The issues I raised below are further improvements in the functionality that can be done and don't directly relate to the patch that was submitted. Sorry if I confused things. --Barry Bruce Momjian wrote: > Can someone suggest what is

Re: [JDBC] Re: Proposal to fix Statement.executeBatch()

2001-08-28 Thread Rene Pijlman
On Tue, 28 Aug 2001 12:31:53 -0400 (EDT), you wrote: >Can someone suggest what is to be done with the propsed patch? Barry's proposal for a more efficient implementation of executeBatch() does not invalidate the patch. It just means we still have more work to do to get the performance improvement

Re: [JDBC] Re: Proposal to fix Statement.executeBatch()

2001-08-28 Thread Bruce Momjian
Can someone suggest what is to be done with the propsed patch? > > What exactly is the behaviour of the backend in that scenario? > > Does it commit every separate SQL statement in the > > semicolon-separated list, or does it commit the list as a whole? > > Does it abort processing the state

Re: [JDBC] Re: Proposal to fix Statement.executeBatch()

2001-08-27 Thread Barry Lind
> What exactly is the behaviour of the backend in that scenario? > Does it commit every separate SQL statement in the > semicolon-separated list, or does it commit the list as a whole? > Does it abort processing the statement list when an error occurs > in one statement? And if it continues,

Re: [JDBC] Re: Proposal to fix Statement.executeBatch()

2001-08-27 Thread Rene Pijlman
On Mon, 27 Aug 2001 11:07:55 -0700, you wrote: [executeBatch() implemented as one round trip] >Here is how I would suggest this be done in a way that is spec >compliant (Note: that I haven't looked at the patch you submited yet, so >forgive me if you have already done it this way, but based on y

[JDBC] Re: Proposal to fix Statement.executeBatch()

2001-08-27 Thread Barry Lind
Rene, I see your statements below as incorrect: > The intended behaviour is to send a set of update/insert/delete/DDL > statements in one round trip to the database. Unfortunately, > this optional JDBC feature cannot be implemented correctly with > PostgreSQL, since the backend only returns