Re: [JDBC] [PATCHES] DatabaseMetadata patch

2001-10-25 Thread Mark Lillywhite
JDBC1 patch attached. I don't have a JDBC1 environment (that I know of) so I haven't even compiled this... sorry :( I also attach a very small patch to correct my email address in the JDBC 2 patch. Apply it or not, it's not important, I just noticed it. Thanks again Cheers Mark > I have applied

Re: [JDBC] [PATCHES] DatabaseMetadata patch

2001-10-24 Thread Bruce Momjian
> The patch is missing the corresponding fix for > jdbc1/DatabaseMetaData.java. Can you resubmit the patch with a fix for > both occurances of the problem? Otherwise the fix looks fine. I have applied the jdbc2 version. It would be nice to have a jdbc1 version too. Thanks. -- Bruce Momj

Re: [JDBC] [PATCHES] DatabaseMetadata patch

2001-10-24 Thread Barry Lind
The patch is missing the corresponding fix for jdbc1/DatabaseMetaData.java. Can you resubmit the patch with a fix for both occurances of the problem? Otherwise the fix looks fine. thanks, --Barry Bruce Momjian wrote: > Here is a patch for DatabaseMetaData to show precision properly. It is

Re: [JDBC] [PATCHES] DatabaseMetadata patch

2001-10-24 Thread Bruce Momjian
Patch applied. Thanks. If you can send a jdbc1 version, that would be great. --- > Here is a patch for DatabaseMetaData to show precision properly. It is > from Mark Lillywhite. I am adding to the patch queue. > > --

Re: [JDBC] [PATCHES] DatabaseMetadata patch

2001-10-24 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > + tuple[8] = > +Integer.toString((attypmod & 0x) - VARHDRSZ).getBytes(); In the backend sources, we subtract VARHDRSZ *first* and then AND with . Not sure if this will ever yield a different result, but I'd say it should be

Re: [JDBC] [PATCHES] DatabaseMetadata patch

2001-10-24 Thread Bruce Momjian
Here is a patch for DatabaseMetaData to show precision properly. It is from Mark Lillywhite. I am adding to the patch queue. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Bl

Re: [JDBC] [PATCHES] DatabaseMetadata patch

2001-10-23 Thread Bruce Momjian
> Attached is a unified diff to DatabaseMetadata from the jdbc2 interface. > It fixes a bug where the metadata does not include the scale/precision > of the database columns. > > We have been using this patch successfully for about 2 years, it would > be great to finally get it into the sources.