Re: [JDBC] JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java)
Thanks for the votes of confidence. I am willing to take on the responsibility if the core committee agrees. Yes, we do. We don't know Java very well and are struggling. It would be nice to have someone who actually know the language applying the patches. :-) -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup.| Drexel Hill, Pennsylvania 19026 ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [JDBC] JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java)
* Tom Lane [EMAIL PROTECTED] wrote: | | Of these #3 seems like the solution that will emerge in the long term | anyway; but do we have candidate patch-meisters now? | | Comments, better ideas, nominations, volunteers? I would like to nominate Barry Lind as he has been doing great work for a long time. Maybe 2-3 of the most active JDBC developers should be given commit access, so we're not dependent on one person to merge in patches. -- Gunnar Rønning - [EMAIL PROTECTED] Senior Consultant, Polygnosis AS, http://www.polygnosis.com/ ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [JDBC] JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java)
I am willing to lend a hand if required Dave -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] On Behalf Of Bruce Momjian Sent: September 6, 2001 4:08 PM To: Rene Pijlman Cc: Tom Lane; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [JDBC] JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java) On Thu, 06 Sep 2001 14:30:49 -0400, you wrote: Ultimately it's the committer's responsibility to have confidence that the patch he applies is good; if he doesn't feel competent to check it himself, he should call for more reviewers. If he does feel sure about it, there's no need for procedural overhead. Agreed. If the committer is in the team of certified reviewers and is willing to review patches, our procedures are basically the same. Any committing assistance would be greatly appreciated, especially for jdbc. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup.| Drexel Hill, Pennsylvania 19026 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://www.postgresql.org/search.mpl ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://www.postgresql.org/search.mpl
Re: [JDBC] JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java)
On Thu, 06 Sep 2001 14:30:49 -0400, you wrote: Ultimately it's the committer's responsibility to have confidence that the patch he applies is good; if he doesn't feel competent to check it himself, he should call for more reviewers. If he does feel sure about it, there's no need for procedural overhead. Agreed. If the committer is in the team of certified reviewers and is willing to review patches, our procedures are basically the same. Any committing assistance would be greatly appreciated, especially for jdbc. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup.| Drexel Hill, Pennsylvania 19026 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://www.postgresql.org/search.mpl
[JDBC] JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java)
Joseph Shraibman [EMAIL PROTECTED] writes: Barry Lind wrote: If you want this patch to be applied it should be sent to the pgsql-patches mail list. I thought that jdbc stuff was preferred to be on the jdbc list. I guess not. Well, patches are patches, and it's easier for the committers to spot proposed patches that go by on pgsql-patches. However, the people who are competent to review JDBC patches all seem to be hanging out on the JDBC list. Seems like there are a couple of ways that we could handle this: 1. First draft of a JDBC patch goes to JDBC list; if it passes muster there then resend to pgsql-patches for application. 2. JDBC patches go to psql-patches only, and interested JDBC people subscribe to pgsql-patches so they can kibitz. 3. We give commit privileges to one or two JDBC regulars, who take responsibility for reviewing and applying JDBC-related patches after discussion on pgsql-jdbc. (This was the old setup with Peter Mount, but he seems not to have many spare cycles for Postgres anymore.) Of these #3 seems like the solution that will emerge in the long term anyway; but do we have candidate patch-meisters now? Comments, better ideas, nominations, volunteers? regards, tom lane ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
