Re: [PATCHES] MinGW patch

2003-09-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > but top_srcdir isn't defined at this point. Perhaps $srcdir? Peter would probably know what to use. regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading through Us

Re: [PATCHES] MinGW patch

2003-09-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > + # We already have this in Makefile.win32, but configure needs it too > > + if test "$PORTNAME" = "win32" > > + then > > + CPPFLAGS="$CPPFLAGS -Isrc/include/port/win32" > > + fi > > This seems unlikely to work when building ou

Re: [PATCHES] MinGW patch

2003-09-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > + # We already have this in Makefile.win32, but configure needs it too > + if test "$PORTNAME" = "win32" > + then > + CPPFLAGS="$CPPFLAGS -Isrc/include/port/win32" > + fi This seems unlikely to work when building outside the source tree.

[PATCHES] MinGW patch

2003-09-06 Thread Bruce Momjian
I have applied the following patch to allow MinGW to again work on CVS. THe patch makes the following changes: o allow configure to see include/port/win32 include files o add matching Win32 accept() prototype o allow pg_id to compile with native Win32 API o fix inv

Re: [PATCHES] minor documentation improvements

2003-09-06 Thread Peter Eisentraut
Neil Conway writes: > So, is upper-case or lower-case better? I'd personally prefer > lower-case, I suppose, but I'm not too bothered either way. If you want to change them all to lowercase, that would be fine by me. At least it would prevent more people being confused into inconsistencies in th