Re: [PATCHES] [HACKERS] obj_description problems?

2003-10-20 Thread Christopher Kings-Lynne
*sigh* - it's really not my day today. Attached is patch that actually compiles and fixes the problem. We will need to bump CATVERSION, and maybe should test all the other qualified functions? Chris Index: src/include/catalog/pg_proc.h

[PATCHES] [Fwd: Re: [HACKERS] obj_description problems?]

2003-10-20 Thread Christopher Kings-Lynne
Doh - this should have been sent to -patches in the first place... Chris Original Message Subject: Re: [HACKERS] obj_description problems? Date: Tue, 21 Oct 2003 13:42:16 +0800 From: Christopher Kings-Lynne <[EMAIL PROTECTED]> To: Christopher Kings-Lynne <[EMAIL PROTECTED]> CC:

Re: [PATCHES] AIX port current

2003-10-20 Thread Tom Lane
"Zeugswetter Andreas SB SD" <[EMAIL PROTECTED]> writes: > #include > + #if defined(__CYGWIN__) || defined(WIN32) > #include /* ensure O_BINARY is available */ > + #endif I don't feel that this will fly. The comment on the #include line is hopelessly out of touch wi

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: >> Is this supposed to be applied to CVS? > Well, yes. Assuming Tom doesn't have any problem with it. In fact, I was just about to apply it myself (had a bit of a problem with the comment still...) regards, tom lane ---

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Christopher Kings-Lynne wrote: > >>Doh.

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Christopher Kings-Lynne
Is this supposed to be applied to CVS? Well, yes. Assuming Tom doesn't have any problem with it. It's a bug in dumping 7.0 databases, which should be fixed so that people can upgrade to 7.4 with less stress :) Chris ---(end of broadcast)--- TI

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Bruce Momjian
Is this supposed to be applied to CVS? --- Christopher Kings-Lynne wrote: > >>Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last > >>thing it does. (Even though there are higher oids in pg_attribute,

Re: [PATCHES] Make pg_dump dump conversions

2003-10-20 Thread Bruce Momjian
This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Christopher Kings-Lynne wrote: > Just noticed a bug in the previous version of the patch. Would fail > against pre-7.3 p

Re: [PATCHES] introduce "default_use_oids"

2003-10-20 Thread Bruce Momjian
This has been saved for the 7.5 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Neil Conway wrote: > On Fri, 2003-10-10 at 05:56, Manfred Koizar wrote: > > On Tue, 30 Sep 2003 20:00:22 -0400, Neil Conwa

Re: [PATCHES] minor HISTORY improvement

2003-10-20 Thread Bruce Momjian
Added. Thanks. --- Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Do you think people are actually doing that, and if they are, wouldn't > > it be obvious how to fix it? Anyone else? > > It would probably

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Christopher Kings-Lynne
Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last thing it does. (Even though there are higher oids in pg_attribute, pg_rewrite and pg_description.), so how about the attached patch? Seems reasonable, but the patch ought to fix the comment just above, preferably with the

Re: [PATCHES] AIX port current

2003-10-20 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Zeugswetter Andreas SB SD wrote: > > On

[PATCHES] pg_autovacuum README patch

2003-10-20 Thread Gaetano Mendola
--- README.good 2003-10-21 02:40:19.0 +0200 +++ README 2003-10-21 02:37:43.0 +0200 @@ -1,3 +1,3 @@ -PG_autovacuum README +pg_autovacuum README @@ -148,8 +148,8 @@ vacuum analyze is performed. -AnalyzeThreshold is equal to: +deleteThreshold is equa

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: >> Won't that result in *everything* being considered a system table? > Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last > thing it does. (Even though there are higher oids in pg_attribute, > pg_rewrite and pg_descriptio

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Christopher Kings-Lynne
Won't that result in *everything* being considered a system table? Doh. Quite right. Well, the 7.0 initdb creates pg_indexes as the last thing it does. (Even though there are higher oids in pg_attribute, pg_rewrite and pg_description.), so how about the attached patch? Chris Index: pg_dump.c

Re: [PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Tom Lane
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: > res = PQexec(g_conn, > ! "SELECT oid from pg_database where datname = 'template1'"); > res = PQexec(g_conn, > ! "SELECT oid FROM pg_class ORDER BY oid DESC LIMIT 1"); Won't that result in

[PATCHES] pg_dump problems against 7.0

2003-10-20 Thread Christopher Kings-Lynne
(Sorry I posted this to -hackers by accident initially) I noticed that the function to get max builtin OID for 7.0 does this: template1=> SELECT oid from pg_database where datname = 'template1'; oid --- 17216 (1 row) However, that is incorrect: template1=> select oid,relname from pg_class

Re: [PATCHES] Make pg_dump dump conversions

2003-10-20 Thread Christopher Kings-Lynne
Just noticed a bug in the previous version of the patch. Would fail against pre-7.3 postgres. Fixed in this new version. Just discard the old. Chris Christopher Kings-Lynne wrote: Save this for 7.5. Nails a TODO item. Chris ? GNUmakefile ? config.log ? config.status ? src/Makefile.global