Re: [PATCHES] ALTER TABLE modifications

2003-11-12 Thread Rod Taylor
On Tue, 2003-11-11 at 23:46, Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Is this to be applied to CVS HEAD? It sounded like large portions were still at the request-for-comment stage... It can be applied to -HEAD without breaking anything or backtracking in feature set (that I

Re: [PATCHES] make check improvement for cygwin

2003-11-12 Thread Jason Tishler
Christopher, On Tue, Nov 11, 2003 at 11:14:44PM -0500, Bruce Momjian wrote: Patch applied to CVS HEAD and 7.4CVS. Thanks. Christopher Kings-Lynne wrote: [snip] Is that README included with the cygwin package, Jason? Because I couldn't find it in mine...? Yes, it is currently located

Re: [PATCHES] ALTER TABLE modifications

2003-11-12 Thread Peter Eisentraut
Rod Taylor writes: ALTER TABLE tab ADD COLUMN col DEFAULT 3, ADD CHECK (anothercol 3); The above combinational syntax is commented out in gram.y. The support framework is used in both the above and below items, but arbitrary statements probably have some issues --

Re: [PATCHES] ALTER TABLE modifications

2003-11-12 Thread Rod Taylor
On Wed, 2003-11-12 at 14:02, Peter Eisentraut wrote: Rod Taylor writes: ALTER TABLE tab ADD COLUMN col DEFAULT 3, ADD CHECK (anothercol 3); I think it's perfectly fine to write two separate ALTER TABLE statements. No need to introduce this nonstandard syntax. Yes, it is certainly fine to

Re: [PATCHES] equal() perf tweak

2003-11-12 Thread Gaetano Mendola
Bruce Momjian wrote: Is there a TODO here? I'm just evaluating the performances of two version the one proposed by Neil and the one in a stl::list fashion. Tom suggested also to see if is the case to implement the function size() constant time or not. Regards Gaetano Mendola.

Re: [PATCHES] make check improvement for cygwin

2003-11-12 Thread Christopher Kings-Lynne
OK, here's a final tweak then. Chris Jason Tishler wrote: Christopher, On Tue, Nov 11, 2003 at 11:14:44PM -0500, Bruce Momjian wrote: Patch applied to CVS HEAD and 7.4CVS. Thanks. Christopher Kings-Lynne wrote: [snip] Is that README included with the cygwin package, Jason? Because I

Re: [PATCHES] [pgsql-hackers-win32] initdb in C

2003-11-12 Thread Tom Lane
What's become of initdb's initial note about who you are? $ initdb The files belonging to this database system will be owned by user postgres. This user must also own the server process. ... etc etc... The first two lines of printout don't seem to be in the highly compatible C version.

Re: [PATCHES] [pgsql-hackers-win32] initdb in C

2003-11-12 Thread Andrew Dunstan
Apologies. Here's the patch. There may be other very minor differences in wording, too. But if that's all I missed I won't think I did too badly :-) cheers andrew Tom Lane wrote: What's become of initdb's initial note about who you are? $ initdb The files belonging to this database system

Re: [PATCHES] [pgsql-hackers-win32] initdb in C

2003-11-12 Thread Andrew Dunstan
OK, this works. cheers andrew Andrew Dunstan wrote: ARRGGHH! It has a typo!. new patch shortly. Andrew Dunstan wrote: Apologies. Here's the patch. There may be other very minor differences in wording, too. But if that's all I missed I won't think I did too badly :-) cheers andrew Tom