This patch fixes a few more uppercase GUC vars. I also removed an
example from the RESET reference page because it seemed completely
redundant.
-Neil
Index: doc/src/sgml/ref/analyze.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src
Neil Conway <[EMAIL PROTECTED]> writes:
> Tom Lane <[EMAIL PROTECTED]> writes:
>> The others are already #ifdef'd out by default, which is more or
>> less what I was suggesting you do with the wal_debug code.
> (FWIW, trace_notify is not #ifdef'd out.)
My mistake --- if you feel like making it so
Tom Lane <[EMAIL PROTECTED]> writes:
> The others are already #ifdef'd out by default, which is more or
> less what I was suggesting you do with the wal_debug code.
(FWIW, trace_notify is not #ifdef'd out.)
But I thought that you (and Peter) were suggesting that this shouldn't
be made a GUC varia
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> It's kind of hard to see what you have really changed. Can you
> provide a summary?
The majority of the changes are in the 3rd patch hunk; ISTM it is
pretty easy to see what has been changed. I spent more time discussing
the differences between VACUU
Neil Conway <[EMAIL PROTECTED]> writes:
> ISTM that there is little distinguishing wal_debug and the following
> GUC vars:
> log_btree_build_stats
> trace_notify
> trace_locks
> trace_userlocks
> trace_lwlocks
> debug_deadlocks
> trace_lock_oidmin
> trace_lock_table
> debug_shared_buffers
> Shoul
Tom Lane <[EMAIL PROTECTED]> writes:
> I agree. Having a special debug variable for WAL seems like a
> short-term thing whose time has passed.
ISTM that there is little distinguishing wal_debug and the following
GUC vars:
log_btree_build_stats
trace_notify
trace_locks
trace_userlocks
trace_lwloc
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> Looks good, but did you have a specific reason to prefer LOCK TABLE over
> plain LOCK?
None other than consistency: the majority of the usages in lock.sgml
already used LOCK TABLE, so I converted the rest over. I don't
particularly prefer one form ov
Tom Lane wrote:
> I agree. Having a special debug variable for WAL seems like a
> short-term thing whose time has passed. You could probably even
> make that code a compile-time option like the others at the
> bottom of pg_config_manual.h.
That seems right. It's never something that a user woul
Kurt Roeckx wrote:
> This patch properly sets the prototype for the on_shmem_exit and
> on_proc_exit functions, and adjust all other related code to use
> the proper types too.
Patch installed.
---(end of broadcast)---
TIP 2: you can get off all li
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> I agree with this, but would it be possible to fold it into the normal
> debug output mechanisms? I don't think debugging WAL is any more
> important nowadays than any other component.
I agree. Having a special debug variable for WAL seems like a
On Thu, Dec 11, 2003 at 10:48:14PM +0100, Peter Eisentraut wrote:
>
> This work is pretty much wasted at this time, because we're about one
> year away from making a new release, and who knows what will be changed
^^
Man, you're pretty pessimistic :-))
Karel
--
11 matches
Mail list logo
