Re: [PATCHES] appendStringInfoString() micro-opt

2004-01-30 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > It occurred to me that there is a potential security problem with code > like: > char *my_str; > my_str = read_from_an_untrusted_source(); > appendStringInfo(buf, my_str); > If my_str contains any formatting characters, this crashes the > backend. I'm not

Re: [PATCHES] appendStringInfoString() micro-opt

2004-01-30 Thread Neil Conway
Neil Conway <[EMAIL PROTECTED]> writes: > I'll put this on the back-burner for now, and repost a complete > patch later if I get around to it. I've applied the following patch (since I'd already gone ahead and done the work) that replaces appendStringInfo(buf, "%s", str) with appendStringInfoStrin

Re: [HACKERS] [PATCHES] v7.4.1 text_position() patch

2004-01-30 Thread Tom Lane
Tatsuo Ishii <[EMAIL PROTECTED]> writes: > It's surprising that nobody noticed the bug until now. It seems it has > been there since 7.3 days. I would like to make a back patch for > 7.3-stable if nobody objects. No objection here. Note that I applied a minimal patch to the 7.4 branch, but a more

Re: [PATCHES] v7.4.1 text_position() patch

2004-01-30 Thread Tatsuo Ishii
> "Korea PostgreSQL Users' Group" <[EMAIL PROTECTED]> writes: > >> Hm. I don't think it can actually fail, because the wchar strings are > >> zero-terminated. > > > [ yes it can ] > > You're right. I was confused at first because I couldn't reproduce the > problem, but then I realized it's beca

Re: [PATCHES] v7.4.1 text_position() patch

2004-01-30 Thread Tom Lane
"Korea PostgreSQL Users' Group" <[EMAIL PROTECTED]> writes: >> Hm. I don't think it can actually fail, because the wchar strings are >> zero-terminated. > [ yes it can ] You're right. I was confused at first because I couldn't reproduce the problem, but then I realized it's because I'm running

Re: [PATCHES] Patch for psql startup clarity

2004-01-30 Thread David Fetter
On Fri, Jan 30, 2004 at 11:53:19PM +0100, Markus Bertheau wrote: > В Птн, 30.01.2004, в 23:45, David Fetter пишет: > > > \? for help on internal slash (i.e. psql) commands > > I think it should be > > \? for help with psql commands That was my 1st thought, but wanted to make a minimal change.

Re: [PATCHES] Patch for psql startup clarity

2004-01-30 Thread Markus Bertheau
Ð ÐÑÐ, 30.01.2004, Ð 23:45, David Fetter ÐÐÑÐÑ: > \? for help on internal slash (i.e. psql) commands I think it should be \? for help with psql commands firstly because the adjective "internal" is really subjective and secondly because the fact that it's internal in whatever way is completely

[PATCHES] Patch for psql startup clarity

2004-01-30 Thread David Fetter
Kind people, Here's a minor patch for psql and related files that turns instances of \? for help on internal slash commands into \? for help on internal slash (i.e. psql) commands I think this makes it clearer exactly what \? does and how it's different from \h Cheers, D -- David Fetter [EM

Re: [PATCHES] v7.4.1 text_position() patch

2004-01-30 Thread Korea PostgreSQL Users' Group
strpos() function ( internal text_postion()) had a bug in unicode database. dsn=> select id,subject, strpos(subject, ' ') from bd_22 where id = 3927; id | subject | strpos --+-+ 3927 | 안녕하세요~ | 0 (1 row) Time: 1.619 ms dsn=> select id,subject, strpos(subject,

Re: [PATCHES] v7.4.1 text_position() patch

2004-01-30 Thread Tom Lane
"Korea PostgreSQL Users' Group" <[EMAIL PROTECTED]> writes: > In src/backend/utils/adt/varlena.c, > 766 line must be exits in block of 'else if (elm >1)' too. > Because, strpos() function make a wrong result in multibyte string. Hm. I don't think it can actually fail, because the wchar strings a

[PATCHES] v7.4.1 text_position() patch

2004-01-30 Thread Korea PostgreSQL Users' Group
In src/backend/utils/adt/varlena.c, 766 line must be exits in block of 'else if (elm >1)' too. Because, strpos() function make a wrong result in multibyte string. line 796 ps1 = p1 = (pg_wchar *) palloc((len1 + 1) * sizeof(pg_wchar)); (void) pg_mb2wcha