Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-12 Thread Fabien COELHO
Dear Bruce, # [PATCHES] notice about costly ri checks (2), Fabien COELHO This one which appears on the web page can also be removed, It is also replaced by version 4. Sorry again for the inconvenience, have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of

Re: [PATCHES] int8 fix for win32

2004-03-12 Thread Bruce Momjian
Patch applied. Thanks. --- Claudio Natoli wrote: Fixes recent changes to test. For immediate application. [Note: int8-exp-three-digits.out needs the same treatment] Will review recent changes for float4/8 and

Re: [PATCHES] [HACKERS] notice about costly ri checks (3)

2004-03-12 Thread Fabien COELHO
Dear Bruce, It is in the queue because I need that narrative for the commit messase. Ok, I get the point. I should have made a fully standalone version with all comments repeated. Thanks, have a nice day, -- Fabien Coelho - [EMAIL PROTECTED] ---(end of

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Tom Lane wrote: Has any of this discussion taken into account the fact that a querystring may contain multiple commands? What does the parser do if one of the statements has an error and the others are OK? The whole thing is rejected. This is just

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Andrew Dunstan
Tom Lane wrote: The current definition of log_statement has no problem because we print the whole string, once, before parsing starts. If you put a printout into the per-parse-tree loop then I think you are going to get multiple printouts of the same string. I didn't intend to - I intended to

Re: [PATCHES] [pgsql-hackers-win32] initdb problen

2004-03-12 Thread Andrew Dunstan
I believe that the attached patch may solve this setlocale() problem, but I do not have a Windows box handy on which to test it. Can somebody who does please try and let us know the results? thanks andrew Andrew Dunstan wrote: the answer is very probably here:

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Bruce Momjian
Andrew Dunstan wrote: It does print it. In fact the example I gave below which is from a real trace shows it being printed. It is just printed after the error message rather than before. You solution doesn't appear to address the problem of what to do if they ask for only DDL and

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Bruce Momjian
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Tom Lane wrote: Has any of this discussion taken into account the fact that a querystring may contain multiple commands? What does the parser do if one of the statements has an error and the others are OK? The whole thing is

Re: [PATCHES] defer statement logging until after parse

2004-03-12 Thread Andrew Dunstan
Bruce Momjian wrote: Well, if that is the question, then I don't want to reorder the query printout from the error. OK. I'll let someone else do it. I have no need for it. Forget I spoke. cheers andrew ---(end of broadcast)--- TIP 8: explain