Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Alvaro Herrera
On Sun, Jun 27, 2004 at 12:49:10AM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > I'll work on adding the Xid-cache to PGPROC and using that in > > TransactionIdIsInProgress and the tqual routines. If you want to work > > on that let me know and I'll handle things like the

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Alvaro Herrera
On Sat, Jun 26, 2004 at 07:56:09PM -0400, Tom Lane wrote: > BTW, it would help to know what parts of the patch you intend to work on > over the next couple of days. I'm reviewing and editorializing right > now with intent to commit soon, so it would be good if we can avoid > tromping on each othe

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I'll work on adding the Xid-cache to PGPROC and using that in > TransactionIdIsInProgress and the tqual routines. If you want to work > on that let me know and I'll handle things like the password file, local > bufmgr refcount, etc. Either one is okay,

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Alvaro Herrera
On Sat, Jun 26, 2004 at 07:56:09PM -0400, Tom Lane wrote: > Do we really need SubtransCutoffXid? AFAICS the reason for having it is > only this claim in RecordTransactionCommit: > > * We can't mark committed subtransactions as fully committed, > * because concurrent transactions

Re: [PATCHES] nested xacts and phantom Xids

2004-06-26 Thread Tom Lane
Do we really need SubtransCutoffXid? AFAICS the reason for having it is only this claim in RecordTransactionCommit: * We can't mark committed subtransactions as fully committed, * because concurrent transactions would see them as committed * and not as in-progress. Lea