Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Hmm ... yes, this could be very ugly indeed, but I haven't even looked > at the executor code so I can't comment. Are executor nodes copyable? Nope, and even if we had support for that the executor tree per se is just the tip of the iceberg. There's a

Re: [PATCHES] PITR Archive Recovery

2004-06-29 Thread Simon Riggs
On Tue, 2004-06-29 at 20:59, Simon Riggs wrote: > On Mon, 2004-06-28 at 21:58, Simon Riggs wrote: > > PITR Archive Recovery, 28 June 2004 > > > > What's in this patch? This my LAST, PLANNED patch before Freeze. Any questions? This is a patch-on-patch, rather than a full patch. To use this, apply

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
On Tue, Jun 29, 2004 at 06:59:20PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > As with the bufmgr.c original patch, I don't really know how to test > > that this actually works. [...] > > I forgot to mention to you that that code didn't work at all, btw. Bad news, I g

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > As with the bufmgr.c original patch, I don't really know how to test > that this actually works. I fooled around with printing what it was > doing during a subtrans commit/abort, and it seems OK, but that's about > it. In what situations can a transact

Re: [PATCHES] plperl patch

2004-06-29 Thread Andrew Dunstan
Andrew Dunstan said: > > There is a new known issue which will be addressed quickly: > - empty string is interpreted as NULL - only undef should translate as > NULL > I have fixes for this, which will appear soon. Details available at http://lists.pgfoundry.org/pipermail/plperlng-devel/2004-June

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
On Sun, Jun 20, 2004 at 08:49:22PM -0400, Tom Lane wrote: > There's a good deal more than that missing :-(. Here are the modules or > actions that are called in CommitTransaction and/or AbortTransaction > that have not yet been touched by the patch: > > localbuf.c (refcounts need fixed same as b

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > - GUC vars are rolled back on subxact abort This did not work very well, but here is a revised GUC patch that I think does work. It requires xact.c to export a function to report the current nesting depth, and requires AtEOXact_GUC to be called in all

Re: [PATCHES] PITR Archive Recovery

2004-06-29 Thread Simon Riggs
On Mon, 2004-06-28 at 21:58, Simon Riggs wrote: > PITR Archive Recovery, 28 June 2004 > > What's in this patch? > > - All of what was in previous PITR Archival patch, including reworking > of all the archiver startup/shutdown code to match that of pgstat > - New code to perform Archive Recovery m

Re: [PATCHES] nested xacts and phantom Xids

2004-06-29 Thread Alvaro Herrera
On Tue, Jun 29, 2004 at 03:22:52PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > - GUC vars are rolled back on subxact abort > > This did not work very well, but here is a revised GUC patch that I think > does work. It requires xact.c to export a function to report the >

Re: [PATCHES] plperl patch

2004-06-29 Thread Andrew Dunstan
Andrew Dunstan wrote: Quick head up - I have a fix for the count hash keys 'fix' I reverted yesterday, and also a patch from Joe Coway to allow returning record and setof record. Revised patch will be forthcoming after some testing. The attached patch (and 2 new files incorporating previous el

Re: [PATCHES] plperl patch

2004-06-29 Thread Andrew Dunstan
Quick head up - I have a fix for the count hash keys 'fix' I reverted yesterday, and also a patch from Joe Coway to allow returning record and setof record. Revised patch will be forthcoming after some testing. cheers andrew ---(end of broadcast)--