Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-09 Thread Tom Lane
"Greg Sabino Mullane" <[EMAIL PROTECTED]> writes: > Would something like this be acceptable?: > (int) PQversionNumber > as a simple interface to the sversion variable? I think "version" is a little too nonspecific. We already have extern int PQprotocolVersion(const PGconn *conn); so consis

Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-09 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > Also, I see no need to write your own code to get the server version. > libpq already does this. It doesn't currently export an API to find it > out, but I'd rather add that than have psql duplicate the effort. Good point. I looked around, and

[PATCHES] Postgresql.conf Documentation change

2004-08-09 Thread Josh Berkus
Tom, Attached is that patch I talked to you about on hackers. It changes the description at the top and uncomments most (but not all) of the lines in an effort to make it clear that commenting is not a way to restore the defaults. I've tested this on my machine and we end up with the exact sa

[PATCHES] CREATE DATABASE with tablespace fix

2004-08-09 Thread Gavin Sherry
Attached is a patch resolving the issue raised here: http://groups.google.com.au/groups?q=tablespaces+group:comp.databases.postgresql.hackers&hl=en&lr=&ie=UTF-8&group=comp.databases.postgresql.hackers&scoring=d&selm=Pine.LNX.4.58.0407281411470.17889%40linuxworld.com.au&rnum=4 When I was testing t

Re: [PATCHES] Small addition to syslogger.c

2004-08-09 Thread Tom Lane
"Greg Sabino Mullane" <[EMAIL PROTECTED]> writes: > + #include Applied, thanks. regards, tom lane ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's da

[PATCHES] Small addition to syslogger.c

2004-08-09 Thread Greg Sabino Mullane
Index: syslogger.c === RCS file: /projects/cvsroot/pgsql-server/src/backend/postmaster/syslogger.c,v retrieving revision 1.4 diff -c -r1.4 syslogger.c *** syslogger.c 6 Aug 2004 19:17:31 - 1.4 --- syslogger.c 9 Aug 2004 19:5

Re: [PATCHES] psql - missing tab-completion support for tablespaces

2004-08-09 Thread Tom Lane
Gaetano Mendola <[EMAIL PROTECTED]> writes: > About this I usefull have in the "rollback to " the list of save > point, I did the autocomplete patch for the nested transaction but I was not > able to retrieve the "active" savepoints, is it really impossible to hack > that part ? There isn't any w

Re: [PATCHES] psql - missing tab-completion support for tablespaces

2004-08-09 Thread Gaetano Mendola
Bruce Momjian wrote: Stefan Kaltenbrunner wrote: When looking through the code I found that there seem to be much more places where the tabcomplete-code is not 100% in sync with what the doc's show as possible syntax. Is there interest in fixing those up (ie qualifing as BUGS that can get fixed dur