Re: [PATCHES] cast pid_t to int when using *printf

2004-10-08 Thread Neil Conway
Bruce Momjian wrote: Tom Lane wrote: Traditionally PIDs fit in 16 bits, let alone 32. I'd recommend that we standardize on casting pid_t to int for printing purposes; Done. Uh, what? Your patch removes the casting of pid_t to int -- Tom was suggesting that we consistently cast pid_t to int. (Als

Re: [PATCHES] [HACKERS] Win32 Version numbering patch

2004-10-08 Thread Bruce Momjian
Tom Lane wrote: > "Dave Page" <[EMAIL PROTECTED]> writes: > > I was hoping this would be in for beta 3, but alas - can someone > > *please* commit the win32 version patch at: > > http://candle.pha.pa.us/mhonarc/patches/msg0.html > > Personally I was holding off in hopes of seeing a cleaner sol

Re: [PATCHES] patch for temporary view from TODO list

2004-10-08 Thread Bruce Momjian
This has been saved for the 8.1 release: http:/momjian.postgresql.org/cgi-bin/pgpatches2 --- Koju Iijima wrote: > Dear community, > > I have implemented temporary view related items as I proposed few days ago. > ht

Re: [PATCHES] cast pid_t to int when using *printf

2004-10-08 Thread Bruce Momjian
Oliver Jowett wrote: > Peter Eisentraut wrote: > > Am Freitag, 24. September 2004 09:34 schrieb Oliver Jowett: > > > >>Neil Conway wrote: > >> > >>>On Fri, 2004-09-24 at 16:51, Oliver Jowett wrote: > >>> > gcc (3.2.3 on Solaris 9) warns about a couple of places where a pid_t is > formatted

Re: [PATCHES] cast pid_t to int when using *printf

2004-10-08 Thread Bruce Momjian
Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > I guess it would be safest to use %ld and cast pid_t to long. Of course, > > this seems a little paranoid -- is there actually a system with > > sizeof(pid_t) != 4? > > Traditionally PIDs fit in 16 bits, let alone 32. I'd recommend tha

Re: [PATCHES] cast pid_t to int when using *printf

2004-10-08 Thread Bruce Momjian
Peter Eisentraut wrote: > Am Freitag, 24. September 2004 11:06 schrieb Magnus Hagander: > > > (Btw., the Windows port defines pid_t as unsigned long; > > > that's surely wrong.) > > > > In what way is that wrong? A PID on Windows is a DWORD, which is an > > unsigned long. Or am I missing something

Re: [PATCHES] [HACKERS] Log line prefix on win32

2004-10-08 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > However, I actually prefer the mail header style of timezone to EST/EDT > > anyway: > > Agreed, but AFAIK there's no portable way to ask strftime for that, > so you're still stuck with a compatibility problem. We could teach > pg_str

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-08 Thread Neil Conway
On Thu, 2004-10-07 at 15:15, Neil Conway wrote: > Indeed, that is true -- that's the better fix IMHO. Barring any > objections I'll commit this fix before end-of-day today. Patch applied -- apologies for the delay. -Neil ---(end of broadcast)---