[PATCHES] transformExpr() refactor

2004-10-27 Thread Neil Conway
This patch refactors transformExpr(): rather than being a monsterous 900 line function, it breaks it up into numerous sub-functions that are invoked by transformExpr() for individual expression types, in the style of transformStmt(). I think this patch is reasonably safe for HEAD (it mostly just r

Re: [PATCHES] pgstat cleanup: use palloc and AllocateFile

2004-10-27 Thread Neil Conway
On Thu, 2004-10-28 at 02:20, Tom Lane wrote: > I'd suggest just allocating the tabstat space in TopMemoryContext. The > extra sub-context is useless overhead, since you don't actually use it > for management purposes. I don't know why I didn't think of that :) Patch applied with your suggested c

Re: [PATCHES] [HACKERS] rmtree() failure on Windows

2004-10-27 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Try putting "RequestCheckpoint(true)" in dbcommands.c just before >> remove_dbtablespaces (about line 630). > seems to do the trick. patch attached. Patch applied. >> Not necessary, as long as you put the checkpoint after the DropBu

Re: [PATCHES] [HACKERS] rmtree() failure on Windows

2004-10-27 Thread Andrew Dunstan
Tom Lane wrote: Try putting "RequestCheckpoint(true)" in dbcommands.c just before remove_dbtablespaces (about line 630). It looks like the bgwriter is not quite up-to-speed for this, either; you should rearrange things near line 350 of bgwriter.c so that smgrcloseall is performed before marking

[PATCHES] dblink crash fix

2004-10-27 Thread Kris Jurka
This makes dblink pass its installcheck test on platforms where snprintf(data, len, "%s", NULL) crash. The code was trying to find a connection by name when it already had an unnamed connection and did not have a name to search with. Kris JurkaIndex: contrib/dblink/dblink.c ===

Re: [PATCHES] [HACKERS] ARC Memory Usage analysis

2004-10-27 Thread Mark Wong
On Mon, Oct 25, 2004 at 11:34:25AM -0400, Jan Wieck wrote: > On 10/22/2004 4:09 PM, Kenneth Marshall wrote: > > > On Fri, Oct 22, 2004 at 03:35:49PM -0400, Jan Wieck wrote: > >> On 10/22/2004 2:50 PM, Simon Riggs wrote: > >> > >> >I've been using the ARC debug options to analyse memory usage on t

Re: [PATCHES] pg_ctl -D canonicalization

2004-10-27 Thread Bruce Momjian
OK, attached patch applied. Your original patch didn't canonicalize the PGDATA environment variable. '-D' takes precidence but it should be accurate. I also updated the comments in canonicalize_path because it does a lot more now that just win to unix path conversion. -

Re: [PATCHES] pgstat cleanup: use palloc and AllocateFile

2004-10-27 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > I changed more_tabstat_space() (which is invoked at various times > indirectly throughout the backend) to allocate memory in its own private > memory context, rather than use malloc() -- we can't just use > CurrentMemoryContext because that may not be suffi

[PATCHES] Updated Turkish translations

2004-10-27 Thread Devrim GUNDUZ
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, http://postgresql.gunduz.org/translation/PostgreSQL-8.0/PgSQL-DilDosyalari/libpq-tr.po http://postgresql.gunduz.org/translation/PostgreSQL-8.0/PgSQL-DilDosyalari/pg_ctl-tr.po http://postgresql.gunduz.org/translation/PostgreSQL-8.0/PgSQL-DilDosyalari

Re: [PATCHES] 8.0-NLS: czech

2004-10-27 Thread Karel Zak
On Wed, 2004-10-27 at 13:24 +0200, Peter Eisentraut wrote: > Please make available the individual PO files, not a patch. The patch > you supplied does not apply cleanly. OK. Please don't forget add "cs" to src/bin/pg_config/nls.mk http://people.redhat.com/kzak/pg-nls-cs-10272004.tar.gz

[PATCHES] contrib/tsearch2 missing LIBS

2004-10-27 Thread Reini Urban
beta4 - cygwin: dllwrap -o tsearch2.dll --dllname tsearch2.dll --def tsearch2.def dict_ex.o dict.o snmap.o stopword.o common.o prs_dcfg.o dict_snowball.o dict_ispell.o dict_syn.o wparser.o wparser_def.o ts_cfg.o tsvector.o rewrite.o crc32.o query.o gistidx.o tsvector_op.o rank.o ts_stat.o sno

Re: [PATCHES] port/ build fix

2004-10-27 Thread Neil Conway
Neil Conway wrote: This trivial patch fixes a missing dependency in src/port/Makefile: if "make install" is run without the "all" target having been previously built, the build fails. Per report from Kris Jurka. Applied. -Neil ---(end of broadcast)---

[PATCHES] sign parsing (was: Re: [HACKERS] to_char/to_number loses sign)

2004-10-27 Thread Karel Zak
On Tue, 2004-10-26 at 13:27 -0400, Tom Lane wrote: > Karel Zak <[EMAIL PROTECTED]> writes: > > Yes, you're right. It strange, but NUM_S missing there. The conversion > > from string to number is less stable part of formatting.c... > > > The patch is in the attachment. > > This patch causes the re

Re: [PATCHES] Translation updates for 7.4/8.0: postgres-ru

2004-10-27 Thread Peter Eisentraut
Serguei Mokhov wrote: > Please install to 7.4 and 8.0 branches when you have > time. Done. ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html

Re: [PATCHES] (Turkish) New translation: psql

2004-10-27 Thread Peter Eisentraut
Nicolai Tufar wrote: > I've began translating psql into Turkish. The file is attached. > > Could you please apply it for 8.0? Done. ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org

Re: [PATCHES] 8.0-NLS: czech

2004-10-27 Thread Peter Eisentraut
Karel Zak wrote: > on URL: > http://people.redhat.com/kzak/pg-nls-cs-21102004.patch.gz > > is new Czech translation of PostgreSQL messages. It's too big for > e-mail attachment and mailing list limit. Please make available the individual PO files, not a patch. The patch you supplied does not app

Re: [PATCHES] Updated pg_ctl Turkish translation

2004-10-27 Thread Peter Eisentraut
Devrim GUNDUZ wrote: > After the latest changes, I've updated pg_ctl Turkish translation: Installed. ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL

Re: [PATCHES] Translation updates for 8.0: initdb-ru, libpq-ru, pg_config-ru, pg_ctl-ru, pg_dump-ru

2004-10-27 Thread Peter Eisentraut
Serguei Mokhov wrote: > Please install the attached Russian translation updates. Done. ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] Updated Turkish translations

2004-10-27 Thread Peter Eisentraut
Devrim GUNDUZ wrote: > http://www.gunduz.org/postgresql/translation/PostgreSQL-8.0/PgSQL-Dil >Dosyalari/pg_config-tr.po > is the updated pg_config translation. > Also, the following are initial translations for libpq and pg_dump: > http://www.gunduz.org/postgresql/translation/PostgreSQL-8.0/PgSQL-D

Re: [PATCHES] HP-UX PA-RISC/Itanium 64-bit Patch and HP-UX 11.23 Patch

2004-10-27 Thread Shinji Teragaito
>> On Tue, 26 Oct 2004 21:27:13 -0600, "Ed L." <[EMAIL PROTECTED]> said: >> > > Shinji Teragaito <[EMAIL PROTECTED]> writes: >> > >> I made a patch to let PostgreSQL work in the LP64 data model on >> > >> HP-UX PA-RISC and HP-UX Itanium platform. > I see Shinji's patch changed the library suffix

Re: [PATCHES] Translation updates: pt_BR

2004-10-27 Thread Peter Eisentraut
Euler Taveira de Oliveira wrote: > I just updated the pt_BR translation. The URL above contain a tarball > with all the updates. Installed. ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES]Update 7 zh_TW message files for 8.0

2004-10-27 Thread Peter Eisentraut
Zhenbang Wei wrote: > Update initdb-zh_TW.po, libpq-zh_TW.po, pg_config-zh_TW.po, > pg_ctl-zh_TW.po, pg_dump-zh_TW.po, postgres-zh_TW.po, and > psql-zh_TW.po. Translate new messages and update invalid entries. Installed. ---(end of broadcast)--- TIP

Re: [PATCHES] pg_ctl -D canonicalization

2004-10-27 Thread Magnus Hagander
> > It seems pg_ctl calls canonicalize_path() only on the path as being > > used to access for example the pid file, and not the path > that is sent > > along to the postmaster. > > Specifically, this causes failure on win32 when a path is > passed with > > a trailing backslash, when it's insi