Re: [PATCHES] Fix for timestamp rouding

2005-05-26 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > OK, I have a new patch, which simplifies the code by using > > TrimTrailingZeros(), gives more consistent subsecond display, and > > subpresses the rounding problem: > > Does anyone have any idea why the existing code is designed to keep the > number of

Re: [PATCHES] psql backslash consistency

2005-05-26 Thread Tom Lane
Greg Sabino Mullane <[EMAIL PROTECTED]> writes: > Attached is my "backslash consistency" patch which basically makes all > the backslash commands behave as \dt does: \d* shows non-system objects, > and \d*S shows system objects. Could we have a way to turn this off? At least for functions and ope

[PATCHES] psql backslash consistency

2005-05-26 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Attached is my "backslash consistency" patch which basically makes all the backslash commands behave as \dt does: \d* shows non-system objects, and \d*S shows system objects. See the archives for more discussion on this. I wrote this patch some tim

Re: [PATCHES] Remove second argument from textToQualifiedNameList

2005-05-26 Thread Neil Conway
Jaime Casanova wrote: i found out that the function textToQualifiedNameList doesn't use the second argument it receive (caller). i suppose in the past was used and now it is useless, if that is the case here is a patch removing. Or are any reasons to keep that argument? Applied to HEAD. Thanks

Re: [PATCHES] Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL

2005-05-26 Thread Oliver Jowett
Tom Lane wrote: Oliver Jowett <[EMAIL PROTECTED]> writes: Here's a patch that adds four new GUCs: tcp_keepalives (defaults to on, controls SO_KEEPALIVE) tcp_keepalives_idle (controls TCP_KEEPIDLE) tcp_keepalives_interval (controls TCP_KEEPINTVL) tcp_keepalives_count (controls TCP_KEEPCN

Re: [PATCHES] Fix for timestamp rouding

2005-05-26 Thread Tom Lane
Bruce Momjian writes: > OK, I have a new patch, which simplifies the code by using > TrimTrailingZeros(), gives more consistent subsecond display, and > subpresses the rounding problem: Does anyone have any idea why the existing code is designed to keep the number of displayed fractional digits e

[PATCHES] Fix for timestamp rouding

2005-05-26 Thread Bruce Momjian
Michael Fuhr wrote: > I'm getting time, timetz, and horology regression failures in HEAD > on Solaris 9 / gcc 3.4.2. So are other machines in the build farm, > such as this one: > > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=shark&dt=2005-05-26%2004:21:00 > > I'm getting the same regressi

Re: [PATCHES] Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL (was Re: [HACKERS] Feature freeze date for 8.1)

2005-05-26 Thread Tom Lane
Oliver Jowett <[EMAIL PROTECTED]> writes: > Here's a patch that adds four new GUCs: > tcp_keepalives (defaults to on, controls SO_KEEPALIVE) > tcp_keepalives_idle (controls TCP_KEEPIDLE) > tcp_keepalives_interval (controls TCP_KEEPINTVL) > tcp_keepalives_count (controls TCP_KEEPCNT) Do yo

Re: [PATCHES] Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL

2005-05-26 Thread Tom Lane
Bruce Momjian writes: > I am not very excited about adding four more GUC variables, and I am > thinking we could just have it use the OS defaults and see if we need > more later, so that would add only one GUC. Huh? "Use the OS defaults" is where we are now. I'm unconvinced of the value of allo

Re: [PATCHES] O_DIRECT for WAL writes

2005-05-26 Thread Neil Conway
ITAGAKI Takahiro wrote: The patch adds a new choice "open_direct" to wal_sync_method. It uses O_DIRECT flags for WAL writes, like O_SYNC. Have you looked at what the performance difference of this option is? For example, these benchmark results seem to indicate that an older version of the pa

Re: [PATCHES] wchareq improvement

2005-05-26 Thread a_ogawa
Bruce Momjian wrote: > > Patch applied with adjustment --- the second part of your patch that > skips comparing the first byte seemed unnecessary. It seemed likely > to cause a cpu stall, so just doing the loop seemed faster. > > Did you test if the second part of your patch actually caused a spe

Re: [PATCHES] Implementation of SQLSTATE and SQLERRM variables

2005-05-26 Thread Peter Eisentraut
Dinesh Pandey wrote: > Is this implementation is available in postgres 8.0.2 ? Or which > version of Postgres? At this time, it's not available anywhere. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 1:

Re: [PATCHES] Implementation of SQLSTATE and SQLERRM variables

2005-05-26 Thread Dinesh Pandey
Is this implementation is available in postgres 8.0.2 ? Or which version of Postgres? Thanks Dinesh Pandey -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Pavel Stehule Sent: Thursday, May 26, 2005 12:47 PM To: Neil Conway Cc: Bruce Momjian; pgsql-patch

[PATCHES] O_DIRECT for WAL writes

2005-05-26 Thread ITAGAKI Takahiro
This patch ticks off the following TODO items: Consider use of open/fcntl(O_DIRECT) to minimize OS caching, especially for WAL writes. The patch adds a new choice "open_direct" to wal_sync_method. It uses O_DIRECT flags for WAL writes, like O_SYNC. I had sent a patch looked like this before (

Re: [PATCHES] Implementation of SQLSTATE and SQLERRM variables

2005-05-26 Thread Pavel Stehule
> I think the docs need more than just "these variables are set when an > exception is raised". > > The patch current resets SQLSTATE and SQLERRM whenever a new block is > entered. So: > > create function trap_exceptions() returns void as $_$ > begin > begin > raise exception 'first e