Patch applied, with documentation updates.
---
Tom Lane wrote:
Inserting into a time field with limited precision rounds off, which
is good except for this case:
regression=# select '23:59:59.9'::time(0);
time
On Thu, Oct 13, 2005 at 09:53:14PM -0400, Bruce Momjian wrote:
Good catch! I have backpatched these fixes to the 8.0 and 7.4 branches
as you suggested, (identical) patches attached.
Thanks Bruce. This was an oversight on my part. I should have committed
to 8.0 branch too. I'm sorry about that.
Bruce Momjian pgman@candle.pha.pa.us writes:
In the patch, notice the old comment that suggests we might need to use
CommandCounterIncrement().
... which you failed to fix in any meaningful way. I'd suggest
/*
* Advance the commmand counter to ensure we see all results
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
In the patch, notice the old comment that suggests we might need to use
CommandCounterIncrement().
... which you failed to fix in any meaningful way. I'd suggest
/*
* Advance the commmand counter to ensure we
Bruce Momjian pgman@candle.pha.pa.us writes:
OK, updated patch.
I was sort of hoping that you would make the comments agree with the
code...
regards, tom lane
---(end of broadcast)---
TIP 5: don't forget to increase your
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
OK, updated patch.
I was sort of hoping that you would make the comments agree with the
code...
Oh, you really read those comments? Fixed and attached.
--
Bruce Momjian| http://candle.pha.pa.us
On Thu, 2005-13-10 at 00:39 -0600, Michael Fuhr wrote:
Correct several typos in the documentation.
Are there any remaining objections to this patch? Otherwise, I'll apply
it within 24 hours.
-Neil
---(end of broadcast)---
TIP 4: Have you
On Fri, Oct 14, 2005 at 06:18:08PM -0400, Neil Conway wrote:
On Thu, 2005-13-10 at 00:39 -0600, Michael Fuhr wrote:
Correct several typos in the documentation.
Are there any remaining objections to this patch? Otherwise, I'll apply
it within 24 hours.
I could submit a version with
