Re: [PATCHES] pg_regress updates for vc++ bulid

2007-01-10 Thread Magnus Hagander
Yes, please. Provided there are no objections and that it looks ok, of course ;-) //Magnus On Tue, Jan 09, 2007 at 05:22:20PM -0500, Bruce Momjian wrote: Would you like this applied? --- Magnus Hagander wrote:

Re: [pgsql-patches] [HACKERS] [PATCHES] SGML index build fix

2007-01-10 Thread Peter Eisentraut
Am Mittwoch, 10. Januar 2007 01:41 schrieb Bruce Momjian: Peter Eisentraut wrote: Bruce Momjian wrote: ? %-A4.tex-ps: %.sgml $(ALLSGML) stylesheet.dsl bookindex.sgml ? $(JADE.tex.call) -V texdvi-output -V '%paper-type%'=A4 -o $@ $ + ifndef DRAFT + [EMAIL PROTECTED] -s

Re: [pgsql-patches] [BUGS] xlog lockup patch (was: BUG #2712: could not fsync

2007-01-10 Thread TANIDA Yutaka
Hi. On Mon, 20 Nov 2006 15:33:33 -0500 (EST) Bruce Momjian [EMAIL PROTECTED] wrote: Thomas H. wrote: me wrote: i've loaded 1gb of data without any xlog-problems, whereas with the 8.2b2 executable it locked up after ~100mb. the xlog-files are cycling... if i need to test for some

Re: [pgsql-patches] [HACKERS] [PATCHES] Last infomask bit

2007-01-10 Thread Heikki Linnakangas
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. I added a comment about the unused bits in the header file. Has anyone bothered to measure the overhead added by having to mask to fetch or store the natts value? This is not a zero-cost

Re: [pgsql-patches] [HACKERS] [PATCHES] Last infomask bit

2007-01-10 Thread Heikki Linnakangas
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: Has anyone bothered to measure the overhead added by having to mask to fetch or store the natts value? This is not a zero-cost improvement. I haven't tested it. Agreed, it does add an AND operation to places where

Re: [pgsql-patches] [HACKERS] [PATCHES] Bundle of patches

2007-01-10 Thread Teodor Sigaev
Nice, thanks a lot. Tom Lane wrote: Teodor Sigaev [EMAIL PROTECTED] writes: Just a freshing for clean applying.. http://www.sigaev.ru/misc/user_defined_typmod-0.11.gz Applied with some revisions, and pg_dump support and regression tests added. regards, tom lane

Re: [pgsql-patches] [PATCHES] fix build on Solaris 10/x86_64 in 64bit mode with Sun

2007-01-10 Thread Stefan Kaltenbrunner
Stefan Kaltenbrunner wrote: on an Intel based Solaris 10U2 box using Sun Studio 11 with -xarch=generic64 we get a compile time failure in contrib/pgcrypto because BYTE_ORDER is not defined. in src/include/port/solaris.h we define it to little endian only for __i386 - however in 64bit mode the

Re: [pgsql-patches] [HACKERS] [PATCHES] Last infomask bit

2007-01-10 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: What? I'm completely lost here. What does log_temp_files have to do with the bits on the tuple header? Nothing, it looks like Bruce replied to the wrong message at one point while these two threads were active ... regards,

Re: [pgsql-patches] [HACKERS] [PATCHES] Last infomask bit

2007-01-10 Thread Bruce Momjian
Heikki Linnakangas wrote: Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. I added a comment about the unused bits in the header file. Has anyone bothered to measure the overhead added by having to mask to fetch or store the natts

Re: [pgsql-patches] [PATCHES] Building libpq/psql with Borland BCC5

2007-01-10 Thread Bruce Momjian
Tom Lane wrote: Gavin Sherry [EMAIL PROTECTED] writes: Can we be sure that a BCC build libpq is even safe to use given the problems seen when using psql? Well, I'd not trust it a lot, but surely we have to get it to build before anyone can debug it ... It does build, but the report is

Re: [pgsql-patches] [HACKERS] [PATCHES] SGML index build fix

2007-01-10 Thread Bruce Momjian
Peter Eisentraut wrote: Am Mittwoch, 10. Januar 2007 01:41 schrieb Bruce Momjian: Peter Eisentraut wrote: Bruce Momjian wrote: ? %-A4.tex-ps: %.sgml $(ALLSGML) stylesheet.dsl bookindex.sgml ? $(JADE.tex.call) -V texdvi-output -V '%paper-type%'=A4 -o $@ $ + ifndef DRAFT

Re: [pgsql-patches] [HACKERS] [PATCHES] Building libpq/psql with Borland BCC5

2007-01-10 Thread Alvaro Herrera
Bruce Momjian wrote: Tom Lane wrote: Gavin Sherry [EMAIL PROTECTED] writes: Can we be sure that a BCC build libpq is even safe to use given the problems seen when using psql? Well, I'd not trust it a lot, but surely we have to get it to build before anyone can debug it ... It

Re: [pgsql-patches] [HACKERS] [PATCHES] Building libpq/psql with Borland BCC5

2007-01-10 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Tom Lane wrote: Gavin Sherry [EMAIL PROTECTED] writes: Can we be sure that a BCC build libpq is even safe to use given the problems seen when using psql? Well, I'd not trust it a lot, but surely we have to get it to build before

Re: [pgsql-patches] [BUGS] xlog lockup patch (was: BUG #2712:

2007-01-10 Thread Bruce Momjian
It was considered too risky to backpatch because we couldn't do sufficient testing. --- TANIDA Yutaka wrote: Hi. On Mon, 20 Nov 2006 15:33:33 -0500 (EST) Bruce Momjian [EMAIL PROTECTED] wrote: Thomas H. wrote:

Re: [pgsql-patches] [HACKERS] [PATCHES] SGML index build fix

2007-01-10 Thread Peter Eisentraut
Bruce Momjian wrote: The rule re-runs the makefile for the specific target, and the target modifies HTML.index, or it is only the HTML rule that modifies that. Only the html rule modifies HTML.index. That was a question I had. If that is true, it has to be: %-A4.tex-ps: %.sgml

Re: [pgsql-patches] [HACKERS] [PATCHES] SGML index build fix

2007-01-10 Thread Bruce Momjian
Peter Eisentraut wrote: Bruce Momjian wrote: The rule re-runs the makefile for the specific target, and the target modifies HTML.index, or it is only the HTML rule that modifies that. Only the html rule modifies HTML.index. That was a question I had. If that is true, it has to be:

Re: [pgsql-patches] [HACKERS] [PATCHES] COPY with no WAL, in certain circumstances

2007-01-10 Thread Jim C. Nasby
On Sat, Jan 06, 2007 at 09:20:53PM -0500, Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Simon Riggs wrote: Reason for no documentation was that CREATE INDEX and CREATE TABLE AS SELECT already use this optimisation, but to my knowledge neither was/is documented on those command

Re: [pgsql-patches] [PATCHES] fix build on Solaris 10/x86_64 in 64bit mode with Sun Studio 11

2007-01-10 Thread Tom Lane
Stefan Kaltenbrunner [EMAIL PROTECTED] writes: in src/include/port/solaris.h we define it to little endian only for __i386 - however in 64bit mode the compiler only defines __amd64 causing YTE_ORDER to be undefined. The other option would be to use __x86 which is defined on all intel

Re: [pgsql-patches] [PATCHES] fix build on Solaris 10/x86_64 in 64bit mode with Sun Studio 11

2007-01-10 Thread Tom Lane
Stefan Kaltenbrunner [EMAIL PROTECTED] writes: on an Intel based Solaris 10U2 box using Sun Studio 11 with -xarch=generic64 we get a compile time failure in contrib/pgcrypto because BYTE_ORDER is not defined. After further thought I changed this to handle either __amd64 or __x86_64 (or both).

Re: [pgsql-patches] [PATCHES] fix build on Solaris 10/x86_64 in 64bit mode with Sun

2007-01-10 Thread Stefan Kaltenbrunner
Tom Lane wrote: Stefan Kaltenbrunner [EMAIL PROTECTED] writes: on an Intel based Solaris 10U2 box using Sun Studio 11 with -xarch=generic64 we get a compile time failure in contrib/pgcrypto because BYTE_ORDER is not defined. After further thought I changed this to handle either __amd64 or

Re: [pgsql-patches] [HACKERS] [PATCHES] Building libpq/psql with Borland BCC5

2007-01-10 Thread Merlin Moncure
On 1/10/07, Alvaro Herrera [EMAIL PROTECTED] wrote: What about a Mingw or VC++ psql with a BCC libpq? Is it possible to link something like that? It would be nice to have the libpq at least able to pass the regression tests. you can use microsoft/mingw compiled DLL files but not library

[pgsql-patches] Remove of .SECONDARY from SGML Makefile

2007-01-10 Thread Bruce Momjian
To get the new html dependency to work properly, I removed the .SECONDARY tag from the Makefile. SECONDARY prevents missing files from being built. Patch attached and applied. The rules now work properly and are less error-prone. -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDB

Re: [pgsql-patches] [BUGS] follow-up: problems with pg_ctl -w

2007-01-10 Thread Bruce Momjian
I have added additional documentation for environment variables for pg_ctl, patch attached. --- Marvin Solomon wrote: [This is meant to be a follow-up of a bug report I sent earlier using the web form. It's not clear

Re: [pgsql-patches] [PATCHES] Building libpq/psql with Borland BCC5

2007-01-10 Thread Bruce Momjian
Patch applied. Thanks. Backpatch to 8.2.X.z --- L Bayuk wrote: The attached patch against PostgreSQL-8.2.1 was discussed on [INTERFACES]. It fixes bcc32.mak makefiles for the Borland BCC compiler to build libpq and

Re: [pgsql-patches] [HACKERS] [PATCHES] Allow the identifier length to be

2007-01-10 Thread Bruce Momjian
Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane wrote: ... why is NAMEDATALEN exported at all?) I think because it used to be used in libpq's notification structure. Yeah, you're probably right. Maybe we should take it out of postgres_ext.h and move it to

Re: [pgsql-patches] [PATCHES] Building libpq/psql with Borland BCC5

2007-01-10 Thread L Bayuk
On Wed, Jan 10, 2007 at 02:53:01PM +1100, Gavin Sherry wrote: ... Can we be sure that a BCC build libpq is even safe to use given the problems seen when using psql? I have high confidence in my BCC-built libpq, in so far as its functions are exposed through the Tcl interface pgtcl-ng. My test

Re: [pgsql-patches] [PATCHES] COPY with no WAL, v2

2007-01-10 Thread Bruce Momjian
Will hold for doc patches. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.

Re: [pgsql-patches] [HACKERS] [PATCHES] wal_checksum = on (default) | off

2007-01-10 Thread Bruce Momjian
Simon Riggs wrote: On Fri, 2007-01-05 at 22:57 -0500, Tom Lane wrote: Jim Nasby [EMAIL PROTECTED] writes: On Jan 5, 2007, at 6:30 AM, Zeugswetter Andreas ADI SD wrote: Ok, so when you need CRC's on a replicate (but not on the master) you Which sounds to me like a good reason to