Re: [PATCHES] WIP CSV logs

2007-06-28 Thread Andrew Dunstan
Andrew Dunstan wrote: Here is a WIP patch of the CSV logs work brought up to date with CVS HEAD. One large change I made was to multiplex the selects on the pipes - previously it waited on one then the other - this seems almost to defeat the purpose of using select() :-) It seems to work

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Tom Lane
Patrick Welche <[EMAIL PROTECTED]> writes: > The thing is, if xml2-config is meant to give the flags necessary to > compile a programme with libxml, then why pick-and-choose which flags > you are going to use? Well, if they gave the flags in a sane format (distinguishing CPPFLAGS from CFLAGS, and

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Andrew Dunstan
Patrick Welche wrote: The one that broke things for me in NetBSD is the rpath flag that got ignored. The thing is, if xml2-config is meant to give the flags necessary to compile a programme with libxml, then why pick-and-choose which flags you are going to use? Should a library we are us

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Patrick Welche
On Thu, Jun 28, 2007 at 02:39:37PM -0400, Andrew Dunstan wrote: > Patrick Welche wrote: > >The first part I needed when configuring --with-libxml. Why go to the > >effort of finding xml2-config, and then disbelieve what it tells you? > > Which in particular are we disbelieving? The one that broke

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Tom Lane
Patrick Welche <[EMAIL PROTECTED]> writes: > The first part I needed when configuring --with-libxml. Why go to the > effort of finding xml2-config, and then disbelieve what it tells you? This proposed change puts CFLAGS into CPPFLAGS; maybe the libxml guys have not understood the difference, but w

Re: [PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Andrew Dunstan
Patrick Welche wrote: I found I needed the enclosed patch when configuring today's CVS - I haven't been keeping up since 8.2beta3. The first part I needed when configuring --with-libxml. Why go to the effort of finding xml2-config, and then disbelieve what it tells you? Which in particu

[PATCHES] configure.in / xml / quoting trouble

2007-06-28 Thread Patrick Welche
I found I needed the enclosed patch when configuring today's CVS - I haven't been keeping up since 8.2beta3. The first part I needed when configuring --with-libxml. Why go to the effort of finding xml2-config, and then disbelieve what it tells you? The second part is a shell quoting problem. As t

Re: [PATCHES] Doc update for pg_start_backup

2007-06-28 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Added a note to the docs that pg_start_backup can take a long time to > finish now that we spread out checkpoints: Rather than suggesting twiddling checkpoint_completion_target, should we suggest a manual CHECKPOINT command before pg_start_backup?

Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-06-28 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > The comment in PreallocXlogFiles is out of date: Yeah, I changed it yesterday ... > As you pointed out, it only preallocates one log file. And there is no > XLOGfile mentioned anywhere else in the source tree. If memory serves, there once was a v

Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-06-28 Thread Greg Smith
On Wed, 27 Jun 2007, Tom Lane wrote: Also, the question of redesigning the bgwriter's LRU scan is still open. I believe that's on Greg's plate, too. Greg's plate was temporarily fried after his house was hit by lightening yesterday. I just got everything back on-line again, so no coding pr

[PATCHES] Doc update for pg_start_backup

2007-06-28 Thread Heikki Linnakangas
Added a note to the docs that pg_start_backup can take a long time to finish now that we spread out checkpoints: *** doc/src/sgml/backup.sgml1 Feb 2007 00:28:16 - 2.97 --- doc/src/sgml/backup.sgml28 Jun 2007 11:44:20 - *** *** 672,678 It does

Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-06-28 Thread Jacob Rief
Tom Lane wrote: > Sure, but we don't break them just on a whim. The bottom line here is > whether we are going to make a real commitment to making C++ usable as > a backend extension language --- and for the reasons I mentioned, that > would entail a lot more than renaming a few identifiers. It w

Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-06-28 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas <[EMAIL PROTECTED]> writes: Here's latest revision of Itagaki-sans Load Distributed Checkpoints patch: Applied with some minor revisions to make some of the internal APIs a bit cleaner; mostly, it seemed like a good idea to replace all those bool parameters w