Re: [PATCHES] HOT latest patch - version 8

2007-07-31 Thread Gregory Stark
Heikki Linnakangas [EMAIL PROTECTED] writes: CREATE INDEX CREATE INDEX CONCURRENTLY - I'm not very familiar with how these, so I'll just shut up.. Here is an addendum for how HOT handles CREATE INDEX and CREATE INDEX CONCURRENTLY. CREATE INDEX There are two

Re: [PATCHES] Export user visible function to make use of convert_to_scalar

2007-07-31 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: Gregory Stark [EMAIL PROTECTED] writes: Attached is a patch which implements, as discussed briefly on -hackers, a . user-visible function to get at the information that convert_to_scalar uses to generate selectivity

Re: [PATCHES] Export user visible function to make use of convert_to_scalar

2007-07-31 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: When complaining I hadn't read the pghackers thread in which you suggested this, and now that I'm caught up on email I remain unconvinced. What do you need convert_to_scalar for in order to display the pg_statistic histogram? You've already got the

Re: [PATCHES] Export user visible function to make use of convert_to_scalar

2007-07-31 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: When complaining I hadn't read the pghackers thread in which you suggested this, and now that I'm caught up on email I remain unconvinced. What do you need convert_to_scalar for in

Re: [PATCHES] Export user visible function to make use of convert_to_scalar

2007-07-31 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: How so? The entries in the histogram are equidistant by definition. Huh? They have equal number of values between them, they're not equidistant in the scalar space. So the area of each bar should be the same but the

Re: [PATCHES] Export user visible function to make use of convert_to_scalar

2007-07-31 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: How so? The entries in the histogram are equidistant by definition. Huh? They have equal number of values between them, they're not equidistant in the scalar space. So the area

[PATCHES] Simple patch to report in log the schema name of the statement

2007-07-31 Thread Ferruccio Zamuner
./src/backend/utils/error/elog.c *** ./src/backend/utils/error/elog.c.orig Wed Aug 1 00:48:55 2007 --- ./src/backend/utils/error/elog.cWed Aug 1 00:53:16 2007 *** *** 68,74 --- 68,76 #include storage/ipc.h #include tcop/tcopprot.h #include utils/memutils.h +

Re: [PATCHES] Export user visible function to make use of convert_to_scalar

2007-07-31 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: You're presuming there exists a linear scalar space to reference the results to. I was planning to use the first and last histogram values for the frame of reference. It could still produce some weird graphs but those

Re: [PATCHES] Simple patch to report in log the schema name of the statement

2007-07-31 Thread Tom Lane
Ferruccio Zamuner [EMAIL PROTECTED] writes: [ patch with no documentation ] I can hardly believe that it's a good idea to include search_path in every log entry --- it'd be unreasonably bulky, not to mention impossible to parse by automatic tools. regards, tom lane

[PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-07-31 Thread Hiroshi Saito
Hi. (sorry, this mail is UTF8) This problem is remarkable in the Japanese windows environment It appears in a log outputSee, - LOG: database system was shut down at 2007-07-31 19:23:25 東京 (標準時) LOG: database system is ready to accept connections LOG: autovacuum launcher started (This

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-07-31 Thread Tom Lane
Hiroshi Saito [EMAIL PROTECTED] writes: [ patch to use pg_strftime in xlog.c ] This code deliberately does not use pg_strftime, for the same reasons that elog.c doesn't use it. I'm inclined to think that an appropriate fix is the same as we use in elog.c, ie, don't use %Z at all under Windows.

Re: [PATCHES] Correction of how to use TimeZone by ControlFile(xlog.c)

2007-07-31 Thread Hiroshi Saito
Hi Tom-san. From: Tom Lane Hiroshi Saito [EMAIL PROTECTED] writes: [ patch to use pg_strftime in xlog.c ] This code deliberately does not use pg_strftime, for the same reasons that elog.c doesn't use it. I'm inclined to think that an appropriate fix is the same as we use in elog.c, ie,