Re: [PATCHES] DTrace probe patch for OS X Leopard

2008-03-13 Thread Robert Lor
Hi Peter, Robert Lor wrote: Attached is the updated patch which addressed all the concerns from Peter and Tom. I believe you're the reviewer of this patch. Any idea when it will be applied? As far as I'm concerned, all the issues that were raised have been addressed in the latest patch

[PATCHES] Suppress compiler warnings on mingw

2008-03-13 Thread ITAGAKI Takahiro
Here is a patch to suppress compiler warnings in mingw build. - Remove unused local variables. - Cast DWORD to unsigned integer explicitly. DWORD is always 32bit integer on both 32bit and 64bit Windows. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center mingw-warnings.patch

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-13 Thread Peter Eisentraut
ITAGAKI Takahiro wrote: - Cast DWORD to unsigned integer explicitly. DWORD is always 32bit integer on both 32bit and 64bit Windows. I think if that is so, you wouldn't need to add any casts. Instead you would only need to use the right format specifier. -- Sent via pgsql-patches mailing

Re: [PATCHES] Suppress compiler warnings on mingw

2008-03-13 Thread ITAGAKI Takahiro
Peter Eisentraut [EMAIL PROTECTED] wrote: ITAGAKI Takahiro wrote: - Cast DWORD to unsigned integer explicitly. DWORD is always 32bit integer on both 32bit and 64bit Windows. I think if that is so, you wouldn't need to add any casts. Instead you would only need to use the right