Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Tom Lane
Greg Smith [EMAIL PROTECTED] writes: On Thu, 3 Apr 2008, Tom Lane wrote: I'd much rather be spending our time and effort on understanding what broke for you, and fixing the code so it doesn't happen again. [ shit happens... ] Completely fair, but I still don't see how this particular patch

Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Greg Smith
On Fri, 4 Apr 2008, Tom Lane wrote: (And you still didn't tell me what the actual failure case was.) Database stops checkpointing. WAL files pile up. In the middle of backup, system finally dies, and when it starts recovery there's a bad record in the WAL files--which there are now

Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Tom Lane
Greg Smith [EMAIL PROTECTED] writes: On Fri, 4 Apr 2008, Tom Lane wrote: (And you still didn't tell me what the actual failure case was.) Database stops checkpointing. WAL files pile up. In the middle of backup, system finally dies, and when it starts recovery there's a bad record in the

Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Greg Smith
On Fri, 4 Apr 2008, Tom Lane wrote: The actual advice I'd give to a DBA faced with such a case is to kill -ABRT the bgwriter and send the stack trace to -hackers. And that's a perfect example of where they're trying to get to. They didn't notice the problem until after the crash. The

Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Tom Lane
Greg Smith [EMAIL PROTECTED] writes: ... If they'd have noticed it while the server was up, perhaps because the last checkpoint value hadn't changed in a long time (which seems like it might be available via stats even if, as you say, the background writer is out of its mind at that point),

Re: [PATCHES] Re: [BUGS] BUG #4070: Join more then ~15 tables let postgreSQL produces wrong data

2008-04-04 Thread Ceschia, Marcello
-Ursprüngliche Nachricht- Von: Tom Lane [mailto:[EMAIL PROTECTED] Gesendet: Donnerstag, 3. April 2008 21:33 An: Heikki Linnakangas Cc: Alvaro Herrera; pgsql-patches; Ceschia, Marcello; PostgreSQL Bugs Betreff: Re: [PATCHES] Re: [BUGS] BUG #4070: Join more then ~15 tables let postgreSQL

Re: [PATCHES] Friendly help for psql

2008-04-04 Thread Bruce Momjian
Greg Sabino Mullane wrote: -- Start of PGP signed section. Why not run help when someone enters help (or HELP ME!) on the command line? \? is hardly an easy thing to remember (and some people can't be bothered to actually read the screen...) I have applied this patch (attached) with a few

Re: [PATCHES] Implemented current_query

2008-04-04 Thread Bruce Momjian
I have applied a modified version of this patch, attached. I made a few changes: o You had current_query() returning 'void' so it didn't work o I removed the dblink regression tests for current_query() as it is now a backend function o Update documentation

Re: [PATCHES] Friendly help for psql

2008-04-04 Thread Bruce Momjian
bruce wrote: Greg Sabino Mullane wrote: -- Start of PGP signed section. Why not run help when someone enters help (or HELP ME!) on the command line? \? is hardly an easy thing to remember (and some people can't be bothered to actually read the screen...) I have applied this patch

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Alvaro Herrera
Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This patch fixes these dependencies around bufpage.h, bufmgr.h

Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Alvaro Herrera
Tom Lane wrote: Greg Smith [EMAIL PROTECTED] writes: ... If they'd have noticed it while the server was up, perhaps because the last checkpoint value hadn't changed in a long time (which seems like it might be available via stats even if, as you say, the background writer is out of its

Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Robert Treat
On Friday 04 April 2008 01:59, Tom Lane wrote: Greg Smith [EMAIL PROTECTED] writes: On Thu, 3 Apr 2008, Tom Lane wrote: I'd much rather be spending our time and effort on understanding what broke for you, and fixing the code so it doesn't happen again. [ shit happens... ] Completely

Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Gregory Stark
Alvaro Herrera [EMAIL PROTECTED] writes: Tom Lane wrote: Greg Smith [EMAIL PROTECTED] writes: ... If they'd have noticed it while the server was up, perhaps because the last checkpoint value hadn't changed in a long time (which seems like it might be available via stats even if, as you

[PATCHES] Replace offnum++ by OffsetNumberNext

2008-04-04 Thread Fujii Masao
This is the patch replace offnum++ by OffsetNumberNext. According to off.h, OffsetNumberNext is the macro prepared to disambiguate the different manipulations on OffsetNumbers. But, increment operator was used in some places instead of the macro. -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE

[PATCHES] plpgsql CASE statement

2008-04-04 Thread Pavel Stehule
Hello I finished this patch. Proposal: http://archives.postgresql.org/pgsql-hackers/2008-01/msg00696.php It's compatible with PL/SQL (Oracle) and SQL/PSM (ANSI). CASE statements is parsed and transformed to CASE expression and statements paths. Result of CASE expression is used as index to

Re: [PATCHES] Expose checkpoint start/finish times into SQL.

2008-04-04 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: These kind of things can be monitored externally very easily, say by Nagios, when the values are available via the database. If you have to troll the logs, it's quite a bit harder to do it. I'm not sure about the right values to export -- last

[PATCHES] Partial match in GIN

2008-04-04 Thread Teodor Sigaev
We (Oleg and me) would like to present patch implements partial match for GIN index and two extensions which use this new feature. We hope that after short review they will be committed to CVS. This work was sponsored by EnterpriseDB. http://www.sigaev.ru/misc/partial_match_gin-0.7.gz

Re: [PATCHES] Replace offnum++ by OffsetNumberNext

2008-04-04 Thread Tom Lane
Fujii Masao [EMAIL PROTECTED] writes: This is the patch replace offnum++ by OffsetNumberNext. According to off.h, OffsetNumberNext is the macro prepared to disambiguate the different manipulations on OffsetNumbers. But, increment operator was used in some places instead of the macro. I wonder

[PATCHES] fixing sql generated features - plpgsql case statement

2008-04-04 Thread Pavel Stehule
Hello I am sorry, I sent wrong patch, I did diff from generated files. Current patch set sql features correctly. Regards Pavel Stehule *** ./doc/src/sgml/plpgsql.sgml.orig 2008-04-04 12:07:12.0 +0200 --- ./doc/src/sgml/plpgsql.sgml 2008-04-04 21:55:08.0 +0200 *** ***

Re: [PATCHES] libpq type system 0.9a

2008-04-04 Thread Alvaro Herrera
Merlin Moncure escribió: Yesterday, we notified -hackers of the latest version of the libpq type system. Just to be sure the right people are getting notified, we are posting the latest patch here as well. Would love to get some feedback on this. I had a look at this patch some days ago,

Re: [PATCHES] libpq type system 0.9a

2008-04-04 Thread Joe Conway
Alvaro Herrera wrote: Merlin Moncure escribió: Yesterday, we notified -hackers of the latest version of the libpq type system. Just to be sure the right people are getting notified, we are posting the latest patch here as well. Would love to get some feedback on this. I had a look at this

Re: [PATCHES] [HACKERS] Minor changes to Recovery related code

2008-04-04 Thread Bruce Momjian
Nice, applied. I only modified some of the documentation wording. I was a little worried that statement_timeout might cancel pg_stop_backup() _before_ it had gotten to waiting for the archive logs to be saved, but based on what little code there is before that block, I think we are OK.

Re: [PATCHES] libpq type system 0.9a

2008-04-04 Thread Andrew Chernow
Joe Conway wrote: Alvaro Herrera wrote: Merlin Moncure escribió: Yesterday, we notified -hackers of the latest version of the libpq type system. Just to be sure the right people are getting notified, we are posting the latest patch here as well. Would love to get some feedback on this. I

Re: [PATCHES] libpq type system 0.9a

2008-04-04 Thread Andrew Chernow
Andrew Chernow wrote: Joe Conway wrote: Alvaro Herrera wrote: Merlin Moncure escribió: Yesterday, we notified -hackers of the latest version of the libpq type system. Just to be sure the right people are getting notified, we are posting the latest patch here as well. Would love to get some

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This patch fixes these

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Zdenek Kotala
Alvaro Herrera napsal(a): Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This patch fixes these dependencies around

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Zdenek Kotala
Tom Lane napsal(a): Alvaro Herrera [EMAIL PROTECTED] writes: Zdenek Kotala wrote: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. This

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Tom Lane
Zdenek Kotala [EMAIL PROTECTED] writes: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. Bruce periodically runs a script that's

Re: [PATCHES] Headers dependencies cleanup

2008-04-04 Thread Zdenek Kotala
Tom Lane napsal(a): Zdenek Kotala [EMAIL PROTECTED] writes: During my work I found some header files, which include useless headers and on other way there are some headers which silently assume that requested header will be included by some other headers file. Bruce periodically runs a