Teodor Sigaev wrote:
- For the routines that need a fake, or lightweight, Relation struct
anyway, there's a new function called
XLogFakeRelcacheEntry(RelFileNode), that returns a palloc'd Relation
struct.
Is that fake structure applicable for ReadBuffer()?
Yes.
--
Heikki Linnakangas
Tom Lane wrote:
Heikki Linnakangas [EMAIL PROTECTED] writes:
Attached is an updated version of my patch to refactor the
XLogOpenRelation/XLogReadBuffer interface, in preparation for the
relation forks patch, and subsequently the FSM rewrite patch.
The code motion in md.c looks fairly bogus;
Heikki Linnakangas [EMAIL PROTECTED] writes:
Tom Lane wrote:
The code motion in md.c looks fairly bogus; was that a copy-and-paste
error?
That's intentional. That check has been moved to smgrcreate(), so that
it's done before calling TablespaceCreateDbSpace(). The reason for that
is that
Alvaro Herrera [EMAIL PROTECTED] writes:
Tom Lane wrote:
... I wonder if it would
be worth refactoring the code so that a multiple-object DROP is
implemented via performMultipleDeletions(). This would have more
than just cosmetic advantages: it would no longer matter what
order you listed
Tom Lane wrote:
After looking again, I think that this is not technically very
difficult, but coming up with something that looks tasteful to everyone
might be tricky. In particular I didn't see a nice way to do it without
using struct ObjectAddress in a bunch of header files that don't
