Re: [PATCHES] GIN improvements

2008-06-17 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: > So, I didn't see any comments/objections and I intend to commit this patch > for > next two days and synchronize 'fast insert into GIN' patch with CVS. > Objections? I think it hasn't really gotten reviewed at all (certainly not by me). If you want oth

Re: [PATCHES] GIN improvements

2008-06-17 Thread Teodor Sigaev
1) multicolumn GIN Unlike other indexes, the performance of search doesn't depends on what column of index (first, last, any subset) is used in search clause. This property can be used in gincostestimate, but I haven't looked on it yet. After some playing I didn't find any mentions in *cost

Re: [PATCHES] Simplify formatting.c

2008-06-17 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > > I moved str_initcap() over into oracle_compat.c and then had initcap() > > convert to/from TEXT to call it. The code is a little weird because > > str_initcap() needs to convert to text to use texttowcs(), so in > > multibyte encodings initcap co