Re: [PATCHES] variadic function support

2008-06-26 Thread Pavel Stehule
2008/6/25 Tom Lane [EMAIL PROTECTED]: Pavel Stehule [EMAIL PROTECTED] writes: Tom Lane wrote: Your point about the syntax is good though. It would be better if the syntax were like create function foo (a text, variadic b int[]) or maybe even better create function foo (a text, variadic b

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Alvaro Herrera
Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: However, as of 2004-10-15, this has not worked. :-( The attached patch is the one that caused the bug --- on non-Unix systems, SYSTEMQUOTE is , meaning zero-length string. I should have seen the bug when I

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: However, as of 2004-10-15, this has not worked. :-( The attached patch is the one that caused the bug --- on non-Unix systems, SYSTEMQUOTE is , meaning zero-length string. I

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Bruce Momjian wrote: , meaning zero-length string. I should have seen the bug when I applied the contributed patch in 2004. So, shouldn't this fix be back-patched? Well, no one has actually complained about the breakage, and it has been a few years. Also there is

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Bruce Momjian wrote: I am attaching a minimal patch that will fix the bug in back branches. Keep in mind that a patched pg_ctl will not be able to restart a backend that was not patched. I think this patch will work for unpatched backends as well. I am still uncertain if it should be

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: Why do we need someone to complain? We know the bug is there. Has the code changed a lot in that area? Do we have the policy of backpatching every fix? I thought it was only the major bugs we fixed in back branches. If someone wants to

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Alvaro Herrera wrote: Why do we need someone to complain? We know the bug is there. Has the code changed a lot in that area? Do we have the policy of backpatching every fix? I thought it was only the major bugs we fixed in back

Re: [PATCHES] [Fwd: Re: [HACKERS] pg_dump additional options for performance]

2008-06-26 Thread Bruce Momjian
Added to July patch queue. Thanks. --- Simon Riggs wrote: Re-sending post as discussed with Bruce... On Sun, 2008-03-23 at 12:45 -0300, Alvaro Herrera wrote: Bruce Momjian wrote: Added to TODO:

[PATCHES] Removal of the patches email list

2008-06-26 Thread Bruce Momjian
We have come to agreement that there is no longer a need for a separate 'patches' email list --- the size of patches isn't a significant issue anymore, and tracking threads between the patches and hackers lists is confusing. I propose we close the patches list and tell everyone to start using

Re: [PATCHES] Fix pg_ctl restart bug

2008-06-26 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Alvaro Herrera wrote: I've always assumed that I'm supposed to backpatch the bugs I fix in HEAD, however far is reasonable. I thought we only backatched major bugs to prevent possible instability when fixing minor bugs.