Re: [PATCHES] [HACKERS] get_relation_stats_hook()

2008-07-10 Thread Simon Riggs
On Thu, 2008-07-10 at 14:59 -0400, Tom Lane wrote: > I think it might be a good idea to prepare an actual working example > of a plug-in that does something with the hook in order to verify > that you've got a useful definition. Thanks, will do. I was waiting for the API, but I see a concrete ex

Re: [PATCHES] [HACKERS] get_relation_stats_hook()

2008-07-10 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Thu, 2008-06-26 at 12:50 -0400, Tom Lane wrote: >> I think you need to move up a level, and perhaps refactor some of the >> existing code to make it easier to inject made-up stats. > I've looked at ways of refactoring this, but the hooks provided here >

Re: [PATCHES] review: table function support

2008-07-10 Thread Pavel Stehule
2008/7/10 Marko Kreen <[EMAIL PROTECTED]>: > On 7/10/08, Pavel Stehule <[EMAIL PROTECTED]> wrote: >> I am sending actualized patch >> >> Regards >> Pavel Stehule >> >> 2008/7/9 Pavel Stehule <[EMAIL PROTECTED]>: >> >> > 2008/7/9 Marko Kreen <[EMAIL PROTECTED]>: >> >> Generally, the patch looks

Re: [PATCHES] review: table function support

2008-07-10 Thread Marko Kreen
On 7/10/08, Pavel Stehule <[EMAIL PROTECTED]> wrote: > I am sending actualized patch > > Regards > Pavel Stehule > > 2008/7/9 Pavel Stehule <[EMAIL PROTECTED]>: > > > 2008/7/9 Marko Kreen <[EMAIL PROTECTED]>: > >> Generally, the patch looks fine. There are few issues still: > >> > >> - plpg

Re: [PATCHES] review: table function support

2008-07-10 Thread Pavel Stehule
Hello, I am sending actualized patch Regards Pavel Stehule 2008/7/9 Pavel Stehule <[EMAIL PROTECTED]>: > 2008/7/9 Marko Kreen <[EMAIL PROTECTED]>: >> Generally, the patch looks fine. There are few issues still: >> >> - plpgsql: the result columns _do_ create local variables. >> AIUI, they shou

Re: [PATCHES] Sorting writes during checkpoint

2008-07-10 Thread Simon Riggs
On Wed, 2008-07-09 at 21:39 -0400, Greg Smith wrote: > On Fri, 4 Jul 2008, Simon Riggs wrote: > > > No action on this seen since last commitfest, but I think we should > do > > something with it, rather than just ignore it. > > Just no action worth reporting yet. Over the weekend I finally > re