Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-28 Thread Ryan Bradetich
Hello all, Just wanted to let everyone know I have committed this patch to the PgFoundry uint project. I have also updated the commit-fest wiki with this status. Thanks to everyone (especially Jaime) for the feedback and reviews. - Ryan -- Sent via pgsql-patches mailing list

Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-21 Thread Ryan Bradetich
Hello Jaime, i'm still seeing the failures in the copy commands (the ones about the paths) I just tested this on a different machine (to get it away from my development environment) I was able to duplicate the failures. It looks like I need to update the expected/ files as well. I will get

Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-15 Thread Ryan Bradetich
Message Resend. I forgot to spit the attachments so they did not make it through the list. Patch 1 of 2 : Base uint type. Patch 2 of 2 : Regression tests. - Ryan On Mon, Sep 15, 2008 at 8:13 AM, Ryan Bradetich [EMAIL PROTECTED] wrote: Hello Jaime, I have the code and regression tests

Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-10 Thread Ryan Bradetich
Hello Jaime, It is taking longer than I expected to implement the scalarltsel and scalargtsel functions for the unsigned integer data type. I am still working on this solution and hope to have an updated patch later this week (or over the weekend at the latest). Just wanted to keep you updated

Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-09 Thread Ryan Bradetich
Hello Jaime, Thank you for the test cases! mmm... i rebuild my test env and it works for me this time... until i execute an analyze. I guess autovacuum executed an auto analyze last time... I am able to duplicate the error you saw in the uint_test2.sql. I am assuming you are seeing this

Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-09 Thread Ryan Bradetich
Hello Tom, On Tue, Sep 9, 2008 at 5:11 AM, Tom Lane [EMAIL PROTECTED] wrote: Ryan Bradetich [EMAIL PROTECTED] writes: I am assuming you are seeing this error in the uint_test1.sql: ERROR: could not find hash function for hash operator 16524 I can bypass the error in uint_test1.sql

Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-08 Thread Ryan Bradetich
Hello Jamie and Tom. Thank you very much for the feedback and reviews. I will attempt to answer all the questions I found in this thread in this one email. If I miss any questions, let me know and I will answer it :) Jamie: Thanks for the feedback on missing comments. I will go back and add

Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-08 Thread Ryan Bradetich
Hello Jaime, the same problem happens in joins, unions, hash, etc... so you have to look at those functions as well Great! Added to the list to check. I am planning to build regression tests for these types to catch these errors in the future. Thanks again for your testing and review! PS:

Re: [PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-09-08 Thread Ryan Bradetich
Hello Jaime, why i need the cast in this case? even if the cast is really necesary (the message seems realy ugly) contrib_regression=# select * from t1 where f1 35; ERROR: unsupported type: 16486 contrib_regression=# select * from t1 where f1 35::uint4; f1 - 36 37 38 Can

[PATCHES] [PgFoundry] Unsigned Data Types [1 of 2]

2008-08-31 Thread Ryan Bradetich
Hello all, I have attempted to send this email 3 times over the last 24 hours. I am not sure what is blocking it, so I am going to break it up into two parts: uint-base.tar.bz2 -- The core of the unsigned integer type. uint-tests.tar.bz2 -- The regression tests. I am suspecting a size