Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Tom Lane
Martijn van Oosterhout writes: > Patch attached. Passes -pedantic on gcc 3.3.5 Applied with some cosmetic cleanups and further fixes for 64-bit problems. regards, tom lane ---(end of broadcast)--- TIP 5: don't forget to inc

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Martijn van Oosterhout
On Fri, Feb 10, 2006 at 02:13:26PM -0500, Tom Lane wrote: > For the most part we say "char" where we can and "unsigned char" only > where it really matters, which is mostly inside code that's > encoding-aware anyway. Well, I've done this and avoided changing any public interfaces. ie the libpq int

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Tom Lane
Martijn van Oosterhout writes: > Does PostgreSQL have a policy on the signedness of strings? For the most part we say "char" where we can and "unsigned char" only where it really matters, which is mostly inside code that's encoding-aware anyway. It was only fairly recently that we cleaned the co

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Martijn van Oosterhout
On Fri, Feb 10, 2006 at 06:16:07PM +0100, Martijn van Oosterhout wrote: > Thanks for the tip. I'm currently merging CVS with my version and > getting a lot of conflicts (whitespace variations). > > It's fairly simple changes AFAICS. Just need to fix the declarations of > a few variables. Does Po

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Martijn van Oosterhout
On Fri, Feb 10, 2006 at 12:09:13PM -0500, Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Martijn van Oosterhout wrote: > > >> I'll try to address these warnings (unless someone beats me to it). > > > > > I am looking at it now but I can't find the compiler flag to get thos

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values

2006-02-10 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Martijn van Oosterhout wrote: > >> I'll try to address these warnings (unless someone beats me to it). > > > I am looking at it now but I can't find the compiler flag to get those > > warnings. I am gcc 2.95.3. > > You'd need a newer compiler. gcc -p

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Tom Lane
Bruce Momjian writes: > Martijn van Oosterhout wrote: >> I'll try to address these warnings (unless someone beats me to it). > I am looking at it now but I can't find the compiler flag to get those > warnings. I am gcc 2.95.3. You'd need a newer compiler. regards, tom l

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values

2006-02-10 Thread Bruce Momjian
Martijn van Oosterhout wrote: -- Start of PGP signed section. > On Fri, Feb 10, 2006 at 11:02:41AM -0500, Tom Lane wrote: > > Bruce Momjian writes: > > > OK, I have applied your patch to psql and Teodor has adjusted the > > > tsearch2 expected results. I can't seem to run pgcrypto without getting

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Martijn van Oosterhout
On Fri, Feb 10, 2006 at 11:02:41AM -0500, Tom Lane wrote: > Bruce Momjian writes: > > OK, I have applied your patch to psql and Teodor has adjusted the > > tsearch2 expected results. I can't seem to run pgcrypto without getting > > PRNG errors, so I expect my SSL is too old. Would you send me yo

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Tom Lane
Bruce Momjian writes: > OK, I have applied your patch to psql and Teodor has adjusted the > tsearch2 expected results. I can't seem to run pgcrypto without getting > PRNG errors, so I expect my SSL is too old. Would you send me your > pgcrypto/regression.diff? Thanks. I fixed that already. Pl

Re: [PATCHES] [COMMITTERS] pgsql: Allow psql multi-line column values to align

2006-02-10 Thread Bruce Momjian
OK, I have applied your patch to psql and Teodor has adjusted the tsearch2 expected results. I can't seem to run pgcrypto without getting PRNG errors, so I expect my SSL is too old. Would you send me your pgcrypto/regression.diff? Thanks. ---