Re: [PATCHES] [GENERAL] Making sure \timing is on

2008-05-13 Thread David Fetter
On Tue, May 13, 2008 at 10:47:40AM -0400, Alvaro Herrera wrote: Tom Lane escribió: Alvaro Herrera [EMAIL PROTECTED] writes: David Fetter escribi?: Thanks for the heads-up :) Second patch attached, this time with some docs. Added to July commitfest. Surely this is merely

Re: [PATCHES] [GENERAL] Making sure \timing is on

2008-05-13 Thread Tom Lane
David Fetter [EMAIL PROTECTED] writes: Surely this is merely proof of concept and not a complete patch. Next patch attached :) Uh, my point was that the agreement was to do this to *all* of psql's toggling backslash commands, not only \timing. regards, tom lane --

Re: [PATCHES] [GENERAL] Making sure \timing is on

2008-05-13 Thread David Fetter
On Tue, May 13, 2008 at 11:36:57AM -0400, Tom Lane wrote: David Fetter [EMAIL PROTECTED] writes: Surely this is merely proof of concept and not a complete patch. Next patch attached :) Uh, my point was that the agreement was to do this to *all* of psql's toggling backslash commands,

Re: [PATCHES] [GENERAL] Making sure \timing is on

2008-05-13 Thread David Fetter
On Tue, May 13, 2008 at 01:53:33PM -0700, David Fetter wrote: On Tue, May 13, 2008 at 11:36:57AM -0400, Tom Lane wrote: David Fetter [EMAIL PROTECTED] writes: Surely this is merely proof of concept and not a complete patch. Next patch attached :) Uh, my point was that the

Re: [PATCHES] [GENERAL] Making sure \timing is on

2008-05-13 Thread Tom Lane
David Fetter [EMAIL PROTECTED] writes: On Tue, May 13, 2008 at 11:36:57AM -0400, Tom Lane wrote: Uh, my point was that the agreement was to do this to *all* of psql's toggling backslash commands, not only \timing. Done :) Hmm, I thought we had a lot more than three that were like this. But

Re: [PATCHES] [GENERAL] Making sure \timing is on

2008-05-13 Thread Alvaro Herrera
Tom Lane escribió: Actually, \a and \H are fairly bogus anyway, because they are toggling a setting that has more than two values. I wonder whether defining the argument as a boolean is really very sane. Perhaps it would be better to take the argument if given as just a regular format