Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-10-02 Thread Bruce Momjian
Documentation patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Simon Riggs wrote: > > > On Tue, 2006-09

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-10-02 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Si

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-21 Thread Csaba Nagy
> True, but running several dozen instances on a single machine will > require a lot more memory (or, conversely, each individual database gets > a lot less memory to use). > > Of course, this is all hand-waving right now... it'd be interesting to > see which approach was actually better. I'm run

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-20 Thread Jim C. Nasby
On Wed, Sep 20, 2006 at 05:50:48PM -0400, Tom Lane wrote: > "Jim C. Nasby" <[EMAIL PROTECTED]> writes: > > My thought is that in many envoronments it would take much beefier > > hardware to support N postmasters running simultaneously than to cycle > > through them periodically bringing the backups

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-20 Thread Tom Lane
"Jim C. Nasby" <[EMAIL PROTECTED]> writes: > My thought is that in many envoronments it would take much beefier > hardware to support N postmasters running simultaneously than to cycle > through them periodically bringing the backups up-to-date. How you figure that? The cycling approach will requ

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-20 Thread Jim C. Nasby
On Wed, Sep 20, 2006 at 04:26:30PM -0400, Tom Lane wrote: > "Jim C. Nasby" <[EMAIL PROTECTED]> writes: > > An advantage to being able to stop the server is that you could have one > > server processing backups for multiple PostgreSQL clusters by going > > through them 1 (or more likely, 2, 4, etc)

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-20 Thread Tom Lane
"Jim C. Nasby" <[EMAIL PROTECTED]> writes: > An advantage to being able to stop the server is that you could have one > server processing backups for multiple PostgreSQL clusters by going > through them 1 (or more likely, 2, 4, etc) at a time, essentially > providing N+1 capability. Why wouldn't y

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-20 Thread Jim C. Nasby
On Wed, Sep 20, 2006 at 02:09:43PM +0100, Simon Riggs wrote: > > But why in the world would you want to stop the slave to do it? ISTM > > we would want to arrange things so that you can copy the slave's files > > while it continues replicating, just as with a standard base backup. > > You can do

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-20 Thread Simon Riggs
> On Tue, 2006-09-19 at 12:13 -0400, Tom Lane wrote: > Also, I'm not sold that the concept is even useful. Apparently the idea > is to offload the expense of taking periodic base backups from a master > server, by instead backing up a PITR slave's fileset --- which is fine. Good. That's the key

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-19 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Simon Riggs wrote: >> + >> + if (startupAfterRecovery) >> + ereport(ERROR, >> + (errmsg("recovery ends normally with startup_after_recovery=false"))); >> + > I find this part of the patch a bit ugly. Isn't there a better way to > exit than throwing

Re: [PATCHES] [HACKERS] Incrementally Updated Backup

2006-09-19 Thread Heikki Linnakangas
Simon Riggs wrote: + + if (startupAfterRecovery) + ereport(ERROR, + (errmsg("recovery ends normally with startup_after_recovery=false"))); + I find this part of the patch a bit ugly. Isn't there a better way to exit than throwing an error that's not really an error? -- Heikki Linnakangas Ent