Re: [PATCHES] [HACKERS] Zeroing damaged pages

2006-03-06 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: + /* Even if zero_damaged_pages is true, we don't want autovacuum zeroing. */ + zero_damaged_pages = false; This is completely incorrect; you need to set the variable via GUC, else it will still be overridden from postgresql.conf if a

Re: [PATCHES] [HACKERS] Zeroing damaged pages

2006-03-06 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: + /* Even if zero_damaged_pages is true, we don't want autovacuum zeroing. */ + zero_damaged_pages = false; This is completely incorrect; you need to set the variable via GUC, else it will still be overridden from

Re: [PATCHES] [HACKERS] Zeroing damaged pages

2006-03-05 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: On Thu, 2006-02-23 at 11:54 -0500, Tom Lane wrote: Hmm it'd probably be a good idea to force zero_damaged_pages OFF in the autovac subprocess. That parameter is only intended for interactive use --- as you say, autovac