Re: [PATCHES] A GUC variable to replace PGBE_ACTIVITY_SIZE

2008-06-24 Thread Heikki Linnakangas
I'd like to see some quick testing of this thing mentioned in the comments: /* * XXX if pgstat_track_activity_query_size is really large, * it might be best to use strcpy not memcpy for copying the * activity string? */ If we make it a GUC, there wil

Re: [PATCHES] A GUC variable to replace PGBE_ACTIVITY_SIZE

2008-06-23 Thread Neil Conway
On Mon, 2008-06-23 at 03:52 +1000, Thomas Lee wrote: > * Should it be possible to set this new variable via a command-line > option ala shared_buffers? I would say not: most parameters cannot be set by special command-line parameters, and this one is not important enough to warrant special treatm

[PATCHES] A GUC variable to replace PGBE_ACTIVITY_SIZE

2008-06-22 Thread Thomas Lee
Attached is a patch providing a new GUC variable called "track_activity_query_size", as previously discussed on pgsql-hackers here: http://archives.postgresql.org/pgsql-hackers/2008-06/msg00814.php This is my first patch for postgres, so I'm sure it may need some love. In particular: * Shoul