Re: [PATCHES] Autovacuum launcher doesn't notice death of postmaster immediately

2007-06-13 Thread Alvaro Herrera
ITAGAKI Takahiro wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > > > No, I meant a "while (sleep 1(or 10) and counter < longtime) check for > > > exit" instead of "sleep longtime". > > > > Ah; yes, what I was proposing (or thought about proposing, not sure if I > > posted it or not) was

Re: [PATCHES] Autovacuum launcher doesn't notice death of postmaster immediately

2007-06-12 Thread ITAGAKI Takahiro
Alvaro Herrera <[EMAIL PROTECTED]> wrote: > > No, I meant a "while (sleep 1(or 10) and counter < longtime) check for > > exit" instead of "sleep longtime". > > Ah; yes, what I was proposing (or thought about proposing, not sure if I > posted it or not) was putting a upper limit of 10 seconds in

Re: [PATCHES] Autovacuum launcher

2007-02-15 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > I think a warning comment is warranted here -- will include it when I > commit the patch. I was thinking the same, but didn't want to create a merge problem for you. Maybe "Individual lock IDs end here" or some such? regards, t

Re: [PATCHES] Autovacuum launcher

2007-02-15 Thread Alvaro Herrera
Tom Lane wrote: I forgot to comment: > This part is very seriously broken: > > diff -c -p -r1.33 lwlock.h > *** src/include/storage/lwlock.h 5 Jan 2007 22:19:58 - 1.33 > --- src/include/storage/lwlock.h 13 Feb 2007 16:58:41 - > *** typedef enum LWLockId > ***

Re: [PATCHES] Autovacuum launcher

2007-02-15 Thread Alvaro Herrera
I've fixed all other problems according to suggestions, including adding a SignalSomeChildren(int signal, bool only_autovac) function to postmaster so that it can shut autovac workers down in case of smart shutdown. Tom Lane wrote: > Making InitPostgres's call API vary depending on > IsAutoVacuum

Re: [PATCHES] Autovacuum launcher

2007-02-14 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Here's the autovacuum launcher patch I'm considering for inclusion. This part is very seriously broken: diff -c -p -r1.33 lwlock.h *** src/include/storage/lwlock.h5 Jan 2007 22:19:58 - 1.33 --- src/include/storage/lwlock.h13 F

[PATCHES] Autovacuum launcher

2007-02-14 Thread Alvaro Herrera
[resending, with the patch gzipped, as the previous one seems to be lost -- I mistakenly sent it to -hackers instead of -patches] Hi, Here's the autovacuum launcher patch I'm considering for inclusion. Possibly controversial stuff: 1. I changed InitPostgres to be able to get a database by OID.

Re: [pgsql-patches] Autovacuum launcher patch

2007-01-29 Thread Markus Schiltknecht
Alvaro Herrera wrote: Hmm, I remember eyeballing that code. Would you mind sending me an URL to that file, or something? Or maybe send me the files themselves? Sure, here's a patch against current CVS. Please remove all the functions referencing to "buffer" and "buffer.h" to compile. Remem

Re: [pgsql-patches] Autovacuum launcher patch

2007-01-29 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > The launcher is a dummy process; it never connects to any database. > > ... Eventually this will need to > > be changed so that the launcher tells the worker exactly what table to > > work on. > > I detect a certain lack of clarity

Re: [pgsql-patches] Autovacuum launcher patch

2007-01-26 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > The launcher is a dummy process; it never connects to any database. > ... Eventually this will need to > be changed so that the launcher tells the worker exactly what table to > work on. I detect a certain lack of clarity of thinking here. Either the