Re: [PATCHES] Avoid needless copy in nodeMaterial

2007-11-04 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Neil Conway wrote: > Attached is a patch that avoids a needless copy of the result tuple in > nodeMaterial, in the ca

Re: [PATCHES] Avoid needless copy in nodeMaterial

2007-10-15 Thread Neil Conway
On Tue, 2007-10-16 at 00:34 -0400, Tom Lane wrote: > Seems like this needs more comments about what's happening, rather > than less ... Fair point. > Also, it looks to me like the plan node's own resultslot might never be > assigned to at all, when the subplan returns zero rows. Does this > corn

Re: [PATCHES] Avoid needless copy in nodeMaterial

2007-10-15 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a patch that avoids a needless copy of the result tuple in > nodeMaterial, in the case that we don't have a previously-materialized > tuple to return. Seems like this needs more comments about what's happening, rather than less ... Also, it lo

[PATCHES] Avoid needless copy in nodeMaterial

2007-10-15 Thread Neil Conway
Attached is a patch that avoids a needless copy of the result tuple in nodeMaterial, in the case that we don't have a previously-materialized tuple to return. We can just return the TTS produced by executing our child node, rather than returning a copy of it. I didn't bother pulling the MinimalTup