Re: [PATCHES] Checkpoint logging, revised patch

2007-06-30 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Greg Smith wrote: >> My original patch converted the buffers written to MB. > I don't think we currently use MB in any other log messages. If we go > down that route, we need to consider switching to MB everywhere. I left this as submitted by Heik

Re: [PATCHES] Checkpoint logging, revised patch

2007-06-30 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > Here's a reworked version Greg Smith's patch for logging checkpoints. Applied with minor editorialization. regards, tom lane ---(end of broadcast)--- TIP 4: Have you searched

Re: [PATCHES] Checkpoint logging, revised patch

2007-06-30 Thread Greg Smith
On Sat, 30 Jun 2007, Heikki Linnakangas wrote: I don't think we currently use MB in any other log messages. If we go down that route, we need to consider switching to MB everywhere. Are there a lot of messages that speak in terms of buffer pages though? Other than the debug-level stuff, which

Re: [PATCHES] Checkpoint logging, revised patch

2007-06-30 Thread Heikki Linnakangas
Greg Smith wrote: On Fri, 29 Jun 2007, Heikki Linnakangas wrote: LOG: checkpoint complete; buffers written=5869 (35.8%); write=2.081 s, sync=4.851 s, total=7.066 s My original patch converted the buffers written to MB. Easier to estimate MB/s by eye; I really came to hate multiplying by 8K.

Re: [PATCHES] Checkpoint logging, revised patch

2007-06-29 Thread Greg Smith
On Fri, 29 Jun 2007, Heikki Linnakangas wrote: LOG: checkpoint complete; buffers written=5869 (35.8%); write=2.081 s, sync=4.851 s, total=7.066 s My original patch converted the buffers written to MB. Easier to estimate MB/s by eye; I really came to hate multiplying by 8K. And people who hav

Re: [PATCHES] Checkpoint logging, revised patch

2007-06-29 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > One thing that's missing, that I originally hoped to achieve with this, > is logging the cause of a checkpoint. Doing that would have required > either sprinkling elogs to all callers of RequestCheckpoint, or adding a > "reason" parameter to it an

[PATCHES] Checkpoint logging, revised patch

2007-06-29 Thread Heikki Linnakangas
Here's a reworked version Greg Smith's patch for logging checkpoints. It adds a GUC variable, log_checkpoints, along the lines of log_connections and log_autovacuum. Enabling it causes two lines to be printed to the system log per checkpoint, like this: LOG: checkpoint starting LOG: checkpoi