Re: [PATCHES] Hash Index Build Patch v2

2008-03-17 Thread Tom Raney
Tom, Thanks for your comments and for your work incorporating our patch into 8.4. This will help us provide even a better patch next time around :) -Shreya Bhargava and Tom Raney Tom Raney <[EMAIL PROTECTED]> writes: This revised version of our patch uses the function estimate_rel_size()

Re: [PATCHES] Hash Index Build Patch v2

2008-03-16 Thread Tom Lane
Tom Raney <[EMAIL PROTECTED]> writes: > This revised version of our patch uses the function estimate_rel_size() > from plancat.c to estimate the number of tuples in the parent relation. > This method is an alternative to scanning the parent relation to > estimate the number of tuples, as we did

Re: [PATCHES] Hash Index Build Patch v2

2007-10-22 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Tom Raney wrote: > This revised version of our patch uses the function estimate_rel_size() > from plancat.c to estim

[PATCHES] Hash Index Build Patch v2

2007-10-21 Thread Tom Raney
This revised version of our patch uses the function estimate_rel_size() from plancat.c to estimate the number of tuples in the parent relation. This method is an alternative to scanning the parent relation to estimate the number of tuples, as we did in the first version of the patch. -Tom #in

Re: [PATCHES] Hash Index Build Patch

2007-09-28 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Tom Raney wrote: > Hello All, > > We have prepared a patch (against CVS HEAD)for the TODO item: > * Hash >-Durin

Re: [PATCHES] Hash Index Build Patch

2007-09-27 Thread Simon Riggs
On Wed, 2007-09-26 at 16:06 -0400, Tom Lane wrote: > Tom Raney <[EMAIL PROTECTED]> writes: > > Alvaro Herrera wrote: > >> Just wondering, wouldn't it be enough to obtain a tuple count estimate > >> by using reltuples / relpages * RelationGetNumberOfBlocks, like the > >> planner does? > > > We thou

Re: [PATCHES] Hash Index Build Patch

2007-09-26 Thread Tom Lane
Tom Raney <[EMAIL PROTECTED]> writes: > Alvaro Herrera wrote: >> Just wondering, wouldn't it be enough to obtain a tuple count estimate >> by using reltuples / relpages * RelationGetNumberOfBlocks, like the >> planner does? > We thought of that and the verdict is still out whether it is more > co

Re: [PATCHES] Hash Index Build Patch

2007-09-26 Thread Tom Raney
Alvaro Herrera wrote: Hi Tom, Tom Raney wrote: We used spool functions from the BTree code to sort the index tuples. Sorting is done on the hash value of the tuples. The hash value depends on the number of primary bucket pages (henceforth just bucket pages) that will be required to fit all

Re: [PATCHES] Hash Index Build Patch

2007-09-26 Thread Alvaro Herrera
Hi Tom, Tom Raney wrote: > We used spool functions from the BTree code to sort the index > tuples. Sorting is done on the hash value of the tuples. The hash > value depends on the number of primary bucket pages (henceforth > just bucket pages) that will be required to fit all the index > tuples.

[PATCHES] Hash Index Build Patch

2007-09-25 Thread Tom Raney
Hello All, We have prepared a patch (against CVS HEAD)for the TODO item: * Hash -During index creation, pre-sort the tuples to improve build speed http://archives.postgresql.org/pgsql-hackers/2007-03/msg01199.php Details of this patch's performance improvements can be found at http://web